Skip to content
Snippets Groups Projects
Commit d55046b3 authored by Vincent Aravantinos's avatar Vincent Aravantinos
Browse files

improves constraint verifier base in case no specific error messages have been defined

refs 2553
parent c1d65364
No related branches found
No related tags found
No related merge requests found
......@@ -36,9 +36,11 @@ import org.fortiss.tooling.kernel.model.constraints.FailVerificationStatus;
import org.fortiss.tooling.kernel.model.constraints.IConstraint;
import org.fortiss.tooling.kernel.model.constraints.IConstraintVerificationStatus;
import org.fortiss.tooling.kernel.model.constraints.OutdatedVerificationStatus;
import org.fortiss.tooling.kernel.model.constraints.SuccessVerificationStatus;
import org.fortiss.tooling.kernel.service.IConstraintVerificationService;
import org.fortiss.tooling.kernel.service.IConstraintVerificationService.IFix;
import org.fortiss.tooling.kernel.ui.extension.IConstraintVerifierUI;
import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService;
/**
* Base class for constraint verification GUI.
......@@ -46,7 +48,7 @@ import org.fortiss.tooling.kernel.ui.extension.IConstraintVerifierUI;
* @author vincent
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 5C9927F236301634847D916815662784
* @ConQAT.Rating YELLOW Hash: 2CAFC35BCE6941999C382DCE461140F1
*/
public class ConstraintVerifierUIBase<T extends IConstraint> implements IConstraintVerifierUI<T> {
......@@ -83,7 +85,7 @@ public class ConstraintVerifierUIBase<T extends IConstraint> implements IConstra
/** {@inheritDoc} */
@Override
public boolean canOpen(IConstraintVerificationStatus status) {
return(status instanceof OutdatedVerificationStatus);
return(!(status instanceof SuccessVerificationStatus));
}
/** Dialog presenting the error/failure and the possible fix(es). */
......@@ -161,8 +163,10 @@ public class ConstraintVerifierUIBase<T extends IConstraint> implements IConstra
/** {@inheritDoc} */
@Override
public String getMessage(IConstraintVerificationStatus status) {
// By default, no message. To be specialized by inheriting classes.
return null;
public String getMessage(IConstraintVerificationStatus s) {
// Default message. Inheriting classes SHOULD specialize.
String name = IModelElementHandlerService.INSTANCE.getName(s.getConstraint());
String pre = s instanceof FailVerificationStatus ? "Error while checking" : "Unsatisfied";
return pre + " constraint" + (name == null ? "." : ": " + name);
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment