reviewed portion of tooling.base.ui

refs 311

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/bendpoint/CommandBase.java

@@ -28,7 +28,7 @@ import org.fortiss.tooling.base.ui.layout.IDiagramLayoutConfiguration;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C20AF7D4BE6A76ABC8C3D7718CBC4B3C
+ * @ConQAT.Rating GREEN Hash: B31A09853BAAFCC6774FBB75602163F0
  */
 public abstract class CommandBase extends Command {
 

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/bendpoint/CreateCommand.java

@@ -29,7 +29,7 @@ import org.fortiss.tooling.base.ui.layout.IDiagramLayoutConfiguration;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: F54B8CAEAFDC426EF43B1AD20EFAA8BC
+ * @ConQAT.Rating GREEN Hash: E3F78C0547ECFC19B561C2C358748DD2
  */
 public class CreateCommand extends CommandBase {
 

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/bendpoint/DeleteCommand.java

@@ -27,7 +27,7 @@ import org.fortiss.tooling.base.model.layout.ILayoutedModelElement;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 7F998FEE020844D7B56A044EA63B669B
+ * @ConQAT.Rating GREEN Hash: 41D2B5D0F59247EBE0CF9B8BAE35DBBA
  */
 public class DeleteCommand extends CommandBase {
 	/** Creates a command to delete a bend point. */

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/command/bendpoint/MoveCommand.java

@@ -29,7 +29,7 @@ import org.fortiss.tooling.base.ui.layout.IDiagramLayoutConfiguration;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 0F784BD73152405FF2AC2A0218EEF587
+ * @ConQAT.Rating GREEN Hash: 7AB19F1BA0FBF6862832B0A3C19D5B5A
  */
 public class MoveCommand extends CommandBase {
 

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/PrettyInsetEllipse.java

@@ -40,13 +40,18 @@ import org.eclipse.ui.plugin.AbstractUIPlugin;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 44874F944EB65D31ADD222EFEBE4E7F6
+ * @ConQAT.Rating RED Hash: D7A97336995AA26EEDBC95C2B49127FA
  */
 public class PrettyInsetEllipse extends Shape {
 
 	/** The transparent insets surrounding this shape. */
 	protected final Insets insets;
 
+	// TODO @review CD: overlay images as well as "fancy" look are currently
+	// omitted. corresponding
+	// preference seems to have disappeared.
+	// -> clean up or re-enable
+
 	/** A complete set of reflections for 3 dimensional ellipses. */
 	protected static final Image reflections = AbstractUIPlugin
 			.imageDescriptorFromPlugin("org.fortiss.tooling.base.ui",

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/PrettyRoundedRectangle.java

@@ -38,7 +38,7 @@ import org.fortiss.tooling.base.ui.ToolingBaseUIActivator;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C452794B56B9A854A801D112102E7571
+ * @ConQAT.Rating RED Hash: 31CAA5E0D8A786AECB929587261F1199
  */
 public class PrettyRoundedRectangle extends Shape {
 
@@ -48,6 +48,11 @@ public class PrettyRoundedRectangle extends Shape {
 	/** The transparent insets surrounding this shape. */
 	protected final Insets insets;
 
+	// TODO @review CD: overlay images as well as "fancy" look are currently
+	// omitted. corresponding
+	// preference seems to have disappeared.
+	// -> clean up or re-enable
+
 	/** A linear blend applied at the top. */
 	protected static final Image linearBlend = ToolingBaseUIActivator
 			.getImageDescriptor("icons/overlay/linear-blend-round.png")

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/figure/TransparentLabel.java

@@ -28,7 +28,7 @@ import org.eclipse.swt.graphics.Image;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: FCEB3C4E0D8E382EF77C10A655B5D26E
+ * @ConQAT.Rating GREEN Hash: A184D1241812E9474BF861243F45F420
  */
 public class TransparentLabel extends Label {
 

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/DiagramLayoutEditPolicy.java

@@ -39,7 +39,7 @@ import org.fortiss.tooling.base.ui.editpart.command.MoveWithinDiagramCommand;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: DC3E049397CBC5F1BA2B9181C1B6C9B7
+ * @ConQAT.Rating RED Hash: FF45F874E12A71D06C92F154DF319D98
  */
 public class DiagramLayoutEditPolicy extends RelayCreateCommandEditPolicyBase {
 
@@ -63,6 +63,7 @@ public class DiagramLayoutEditPolicy extends RelayCreateCommandEditPolicyBase {
 		return super.getCommand(request);
 	}
 
+	// TODO @review CD: clone with ElementLayoutEditPolicy -> move to superclass
 	/** {@inheritDoc} */
 	@Override
 	protected Command getMoveChildrenCommand(final Request request) {

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/DirectConnectionAndReconnectionEditPolicy.java

@@ -79,7 +79,7 @@ import org.fortiss.tooling.base.ui.editpart.command.ReconnectCommand;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 5E51B2FE87A0DD81B893266DF0F921A7
+ * @ConQAT.Rating GREEN Hash: D8A22F06435D834C09320DF50A0AC1E6
  */
 public class DirectConnectionAndReconnectionEditPolicy extends GraphicalNodeEditPolicy {
 

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ElementLayoutEditPolicy.java

@@ -39,7 +39,7 @@ import org.fortiss.tooling.kernel.model.INamedCommentedElement;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: F419FCA55F52F78F6EB0C7D80AF32627
+ * @ConQAT.Rating RED Hash: E074E4EB7529C3D44215580F3AAB6932
  */
 public class ElementLayoutEditPolicy<T extends ILayoutedModelElement & INamedCommentedElement>
 		extends RelayCreateCommandEditPolicyBase {
@@ -63,6 +63,7 @@ public class ElementLayoutEditPolicy<T extends ILayoutedModelElement & INamedCom
 		return new NonResizableEditPolicy();
 	}
 
+	// TODO @review CD: clone with ElementLayoutEditPolicy -> move to superclass
 	/** {@inheritDoc} */
 	@Override
 	protected Command getMoveChildrenCommand(Request request) {

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/ElementMoveAndSouthEastResizeEditPolicy.java

@@ -33,7 +33,7 @@ import org.fortiss.tooling.base.ui.layout.IDiagramLayoutConfiguration;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: AAEA0E1D305C993E7B537022F5E08D56
+ * @ConQAT.Rating GREEN Hash: 41C820EF5786DD7A1FDF31BBD9DE8750
  */
 public class ElementMoveAndSouthEastResizeEditPolicy extends
 		ResizableEditPolicy {

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/RelayCreateCommandEditPolicyBase.java

@@ -43,7 +43,7 @@ import org.fortiss.tooling.kernel.ui.dnd.ElementCompositionSource;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: D5598BDF64C5B05903EFF2697623FF08
+ * @ConQAT.Rating RED Hash: 0D7A3CEE777E39AE87521E2458B76977
  */
 public abstract class RelayCreateCommandEditPolicyBase extends LayoutEditPolicy {
 
@@ -69,6 +69,7 @@ public abstract class RelayCreateCommandEditPolicyBase extends LayoutEditPolicy
 	 * {@link CreateConnectionCompositionRequest}s.
 	 */
 	private Command getCreateCompositionCommand(CreateRequest request) {
+		// TODO @review CD: sure? if(NEQ null) return null ?
 		if (request.getSize() != null) {
 			return null;
 		}

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/RemoveEditPolicy.java

@@ -36,7 +36,7 @@ import org.fortiss.tooling.kernel.service.IElementCompositorService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 4232502D94974A218397D3B424BAC8F6
+ * @ConQAT.Rating GREEN Hash: 998816E233579A017ECF221071C5AE43
  */
 public final class RemoveEditPolicy extends ComponentEditPolicy {
 

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/policy/StickyConnectorMoveEditPolicy.java

@@ -36,7 +36,7 @@ import org.fortiss.tooling.kernel.model.INamedCommentedElement;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 8110A25B9CBE5E500D64C19E30930203
+ * @ConQAT.Rating GREEN Hash: 1B77B2172B1F69F71793AE075478C83D
  */
 public class StickyConnectorMoveEditPolicy<T extends ILayoutedModelElement & INamedCommentedElement>
 		extends NonResizableEditPolicy {

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/request/CreateConnectionCompositionRequest.java

@@ -26,7 +26,7 @@ import org.fortiss.tooling.kernel.ui.dnd.ConnectionCompositionSource;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: B93D082E2E002B99375113DA1EB88D88
+ * @ConQAT.Rating GREEN Hash: 87D2C82FE89A400320BDC1736B6D28A8
  */
 public final class CreateConnectionCompositionRequest extends CreateRequest {
 

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/request/CreateElementCompositionRequest.java

@@ -26,7 +26,7 @@ import org.fortiss.tooling.kernel.ui.dnd.ElementCompositionSource;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 4AFD2FFEC9BBA10DA587C2C60BBB3030
+ * @ConQAT.Rating GREEN Hash: 1DAE7E8D26B307774D480861A73F011C
  */
 public final class CreateElementCompositionRequest extends CreateRequest {
 

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/internal/command/GEF2ToolingKernelCommandStack.java

@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.service.IPersistencyService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 36BC8F3F5C8F517385ABFE5C25AF23C4
+ * @ConQAT.Rating GREEN Hash: 9C0EE6817DD32C8F8438882B0D70CCE9
  */
 public class GEF2ToolingKernelCommandStack extends CommandStack implements
 		CommandStackListener {

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/DiagramLayoutConfigurationBase.java

@@ -35,7 +35,7 @@ import org.fortiss.tooling.base.ui.utils.LayoutDataUtils;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 3FC45A524204AC8017B6BD0DD6C39F53
+ * @ConQAT.Rating GREEN Hash: EF00B19637E466A1379619B8C28F6025
  */
 public abstract class DiagramLayoutConfigurationBase implements
 		IDiagramLayoutConfiguration {

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/EllipseCurveLayoutDiagramConfiguration.java

@@ -46,7 +46,7 @@ import org.fortiss.tooling.base.ui.utils.EllipseLayoutUtils.Polar;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 5A21454DFA8BB5D5BF5D3A4854891299
+ * @ConQAT.Rating GREEN Hash: 15F97A0D63FF406F7D107915D03B110F
  */
 public class EllipseCurveLayoutDiagramConfiguration extends
 		DiagramLayoutConfigurationBase {

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/layout/IDiagramLayoutConfiguration.java

@@ -47,7 +47,7 @@ import org.fortiss.tooling.base.ui.editpart.StickyConnectorEditPartBase;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 9FE7ED88B0F8AEA11D364519BE7CEFFC
+ * @ConQAT.Rating GREEN Hash: 0E1648BC8770BAFA3BB01FE58F2132F0
  */
 public interface IDiagramLayoutConfiguration {