RED

refs 2255

org.fortiss.tooling.base/trunk/src/org/fortiss/tooling/base/migration/IDMigrationProvider.java

@@ -42,6 +42,7 @@ public class IDMigrationProvider implements IMigrationProvider {
 	public boolean needMigration(ITopLevelElement modelElement,
 			Map<EObject, AnyType> unknownFeatures) {
 		// if the id of model element is 0
+		// TODO(VA,B11 & C1)
 		if(modelElement != null && modelElement.getRootModelElement() != null &&
 				hasMissingIDs(modelElement.getRootModelElement())) {
 			return true;

org.fortiss.tooling.base/trunk/src/org/fortiss/tooling/base/model/base/impl/DerivedAnnotationBaseStaticImpl.java

@@ -42,6 +42,8 @@ public class DerivedAnnotationBaseStaticImpl {
 	 * @return See above.
 	 */
 	public static <T> T getValue(IDerivedAnnotation<T> annotation) {
+		// TODO(VA) Am I right that annotation.getDerivedValue entails a calculation?
+		// If so it would benefit being stored into a local variable instead of being called twice.
 		if(annotation.getUserAnnotatedValue() != null &&
 				(annotation.isUserAnnotatedValuePreferred() || annotation.getDerivedValue() == null)) {
 			return annotation.getUserAnnotatedValue();

org.fortiss.tooling.base/trunk/src/org/fortiss/tooling/base/utils/AnnotationUtils.java

@@ -51,6 +51,7 @@ public class AnnotationUtils {
 	private static <T extends IAnnotatedSpecification> T getAnnotation(
 			final IModelElement modelElement, EClass eClass) {
 
+		// TODO(VA, B11)
 		final T annotation =
 				(T)pickFirstInstanceOf((Class<IAnnotatedSpecification>)eClass.getInstanceClass(),
 						modelElement.getSpecifications());
@@ -115,7 +116,7 @@ public class AnnotationUtils {
 			}
 
 			// Retrieve annotation / create if the creation does not need to be wrapped into a
-			// command
+			// command.
 			return getAnnotation(modelElement, eClass);
 		}
 
@@ -137,6 +138,7 @@ public class AnnotationUtils {
 		EList<T> parentSpecificationList = new BasicEList<T>();
 		List<IModelElement> parentsElements = getParentsWithType(startElement, IModelElement.class);
 		for(IModelElement currentParentElement : parentsElements) {
+			// TODO(VA, B11)
 			parentSpecificationList.add(pickFirstInstanceOf(clazz,
 					currentParentElement.getSpecifications()));
 		}