Skip to content
Snippets Groups Projects
Commit ed8630fd authored by Sabine Teufl's avatar Sabine Teufl
Browse files

Review

refs 311
parent b48b868c
No related branches found
No related tags found
No related merge requests found
...@@ -54,7 +54,6 @@ import org.osgi.framework.Bundle; ...@@ -54,7 +54,6 @@ import org.osgi.framework.Bundle;
* @version $Rev$ * @version $Rev$
* @ConQAT.Rating YELLOW Hash: 4F70931B343453F4C70065EF91708C65 * @ConQAT.Rating YELLOW Hash: 4F70931B343453F4C70065EF91708C65
*/ */
// TODO: add information for which option (XML file) this class is implemented
public class PersistencyService implements IPersistencyService { public class PersistencyService implements IPersistencyService {
/** The prototype provider extension point ID. */ /** The prototype provider extension point ID. */
...@@ -106,8 +105,6 @@ public class PersistencyService implements IPersistencyService { ...@@ -106,8 +105,6 @@ public class PersistencyService implements IPersistencyService {
@Override @Override
public synchronized boolean isDirty() { public synchronized boolean isDirty() {
for (ITopLevelElement context : contextCache) { for (ITopLevelElement context : contextCache) {
// TODO: warum kann man das nicht unsaved nennen, sondern nennt es
// dirty, wenn unsaved gemeint ist?
if (context.isDirty()) { if (context.isDirty()) {
return true; return true;
} }
......
...@@ -69,7 +69,6 @@ public interface IPersistencyService { ...@@ -69,7 +69,6 @@ public interface IPersistencyService {
ITopLevelElement getTopLevelElementFor(EObject modelElement); ITopLevelElement getTopLevelElementFor(EObject modelElement);
/** Returns whether the some storage provider has unsaved changes. */ /** Returns whether the some storage provider has unsaved changes. */
// TODO: warum nennt man unsaved dirty?
boolean isDirty(); boolean isDirty();
/** Saves any dirty top-level elements to disk. */ /** Saves any dirty top-level elements to disk. */
......
...@@ -39,7 +39,8 @@ public interface IPersistencyServiceListener { ...@@ -39,7 +39,8 @@ public interface IPersistencyServiceListener {
void topLevelElementRemoved(ITopLevelElement element); void topLevelElementRemoved(ITopLevelElement element);
/** Notifies the listener that the underlying persistent model has changed. */ /** Notifies the listener that the underlying persistent model has changed. */
// Would it be useful to have the information (here: persistent model) in // TODO: Would it be useful to have the information (here: persistent model)
// in
// the name? // the name?
void topLevelElementChanged(ITopLevelElement element); void topLevelElementChanged(ITopLevelElement element);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment