unde/redo actions finally work

some clean up

org.fortiss.tooling.base.ui/trunk/src/org/fortiss/tooling/base/ui/editpart/GraphicalEditPartBase.java

@@ -86,4 +86,16 @@ public abstract class GraphicalEditPartBase<T extends EObject> extends
 		modelElement.eAdapters().remove(fullRefreshAdapter);
 		super.deactivate();
 	}
+
+	/** {@inheritDoc} */
+	@SuppressWarnings("rawtypes")
+	@Override
+	public Object getAdapter(Class key) {
+		// EObjectSelectionUtils requires us to adapt to EObject, since
+		// graphical edit parts can be provided as selection as well.
+		if (key == EObject.class) {
+			return modelElement;
+		}
+		return super.getAdapter(key);
+	}
 }

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/EObjectActionBase.java

@@ -29,7 +29,6 @@ import org.eclipse.jface.resource.ImageDescriptor;
  * @version $Rev$
  * @ConQAT.Rating YELLOW Hash: 39A7CCEBD43D310CCB0F78BF6714E3AE
  */
-// TODO (FH): move to UI
 public abstract class EObjectActionBase extends Action {
 
 	/** Stores the target {@link EObject}. */

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/ModelElementHandlerBase.java

@@ -33,7 +33,6 @@ import org.fortiss.tooling.kernel.ui.interfaces.IModelElementHandler;
  * @version $Rev$
  * @ConQAT.Rating YELLOW Hash: D35DD317B0C9AB5C153A5FEB5BC870EE
  */
-// TODO (FH): move UI parts
 public abstract class ModelElementHandlerBase<T extends EObject> implements
 		IModelElementHandler<T> {
 

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/PropertySectionBase.java

@@ -43,7 +43,6 @@ import org.eclipse.ui.views.properties.tabbed.TabbedPropertySheetPage;
  * @version $Rev$
  * @ConQAT.Rating RED Hash: 52DBB44E0AFA61A036B9C2A5297E3BA5
  */
-// TODO (FH): move to UI
 public abstract class PropertySectionBase extends AbstractPropertySection {
 
 	/** Label width. */

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IBindingEditorPageChangeListener.java

@@ -27,7 +27,6 @@ import org.fortiss.tooling.kernel.ui.internal.editor.BindingEditor;
  * @version $Rev: 18709 $
  * @ConQAT.Rating YELLOW Hash: 6A3E42B1BE8519EA4B528FBF2E8D3F0A
  */
-// TODO (FH): move to UI
 public interface IBindingEditorPageChangeListener {
 
 	/** Indicates a page change. */

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/ICustomMenuContributor.java

@@ -31,7 +31,6 @@ import org.fortiss.tooling.kernel.ui.services.IContextMenuService;
  * @version $Rev$
  * @ConQAT.Rating RED Hash: 2EACD5609822D5747074DB89E6956349
  */
-// TODO (FH): move to UI
 public interface ICustomMenuContributor {
 
 	/** Returns the contributed items, i.e., actions or menus. */

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IEditorBinding.java

@@ -29,7 +29,6 @@ import org.fortiss.tooling.kernel.interfaces.IEObjectAware;
  * @version $Rev$
  * @ConQAT.Rating YELLOW Hash: 4AC49B113174D91D434A480C3456423F
  */
-// TODO (FH): move to UI
 public interface IEditorBinding<T extends EObject> extends
 		IEObjectAware<EObject> {
 

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ActionService.java

@@ -42,7 +42,7 @@ import org.fortiss.tooling.kernel.ui.util.EObjectSelectionUtils;
  * @author hoelzlf
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 5DDB14A5557BDA2375928D87F4F4B2BB
+ * @ConQAT.Rating YELLOW Hash: 0DEA10AF5172CF62CC2C422274B84220
  */
 public class ActionService implements IActionService,
 		ITopLevelElementChangeListener, CommandStackListener {
@@ -102,7 +102,15 @@ public class ActionService implements IActionService,
 
 	/** Constructor. */
 	public ActionService() {
+		globalUndoAction.setId(ActionFactory.UNDO.getId());
+		globalRedoAction.setId(ActionFactory.REDO.getId());
+		globalDeleteAction.setId(ActionFactory.DELETE.getId());
 
+		for (ITopLevelElementContext context : IPersistencyService.INSTANCE
+				.getTopLevelElementContexts()) {
+			context.addCommandStackListener(this);
+		}
+		IPersistencyService.INSTANCE.addTopLevelElementListener(this);
 	}
 
 	/** {@inheritDoc} */
@@ -116,13 +124,11 @@ public class ActionService implements IActionService,
 	/** {@inheritDoc} */
 	@Override
 	public void registerGlobalActions(IActionBars actionBars) {
-		globalUndoAction.setId(ActionFactory.UNDO.getId());
 		globalUndoAction.setActionDefinitionId(ActionFactory.UNDO
 				.getCommandId());
 		actionBars.setGlobalActionHandler(ActionFactory.UNDO.getId(),
 				globalUndoAction);
 
-		globalRedoAction.setId(ActionFactory.REDO.getId());
 		globalRedoAction.setActionDefinitionId(ActionFactory.REDO
 				.getCommandId());
 		actionBars.setGlobalActionHandler(ActionFactory.REDO.getId(),

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ContextMenuService.java

@@ -35,7 +35,6 @@ import org.fortiss.tooling.kernel.ui.services.IContextMenuService;
  * @version $Rev$
  * @ConQAT.Rating RED Hash: 28C94C43A9B4498417187CD8F0EFBC57
  */
-// TODO (FH): move to UI
 public class ContextMenuService implements IContextMenuService {
 
 	/** {@inheritDoc} */

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelElementService.java

@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.ui.services.IModelElementService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating RED Hash: BF8801A688B2F4465A25325299BF0215
+ * @ConQAT.Rating YELLOW Hash: 9D99C615FF981BE0831593DC3600D498
  */
 public class ModelElementService extends
 		EObjectAwareServiceBase<IModelElementHandler<EObject>> implements

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/NavigatorService.java

@@ -47,7 +47,7 @@ import org.fortiss.tooling.kernel.ui.util.EObjectSelectionUtils;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 0DBA8B19BC7741F646B0FECB369E177F
+ * @ConQAT.Rating YELLOW Hash: B7F899DC2CFB74320D2F7A19A2D5FEBB
  */
 public class NavigatorService implements INavigatorService,
 		ITopLevelElementChangeListener, CommandStackListener {

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/PropertiesService.java

@@ -25,9 +25,9 @@ import org.fortiss.tooling.kernel.ui.services.IPropertiesService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating RED Hash: 923634855866E1E514EC11821EC8506A
+ * @ConQAT.Rating YELLOW Hash: 37CDABB5D03E1D2F534D83EB55855351
  * 
  */
 public class PropertiesService implements IPropertiesService {
-
+	// nothing to do yet
 }

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/LibraryView.java

@@ -55,7 +55,6 @@ import org.fortiss.tooling.kernel.ui.services.IModelElementService;
  * @version $Rev: 18709 $
  * @ConQAT.Rating RED Hash: A43DAF31B100FF92B123EA6A31C86CBA
  */
-// TODO (FH): move to UI
 public class LibraryView extends ViewPart {
 
 	/** The viewer. */

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IActionService.java

@@ -23,12 +23,12 @@ import org.fortiss.tooling.kernel.ui.internal.ActionService;
 
 /**
  * The action service manages registration and execution of actions including
- * global actions like undo and redo.
+ * global actions like undo, redo, and delete.
  * 
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 11C327F4AFE805D0DA6CB14BF7021FB9
+ * @ConQAT.Rating YELLOW Hash: 2B3895F36532E6A497B12746C07D91D8
  */
 public interface IActionService {
 
@@ -38,9 +38,13 @@ public interface IActionService {
 	/** Registers global actions with the given {@link IActionBars}. */
 	void registerGlobalActions(IActionBars actionBars);
 
-	/** Adds the global default actions like undo to the given context menu. */
+	/** Adds the global default actions to the given context menu. */
 	void addGlobalDefaultActionSectionToMenu(IMenuManager menuManager);
 
-	/** Refreshes the enabled state of the global actions. */
+	/**
+	 * Refreshes the enabled state of the global actions. This method should be
+	 * called when a selection changes. It is automatically called by the action
+	 * service when any command stack changes.
+	 */
 	void refresh();
 }

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IContextMenuService.java

@@ -28,9 +28,8 @@ import org.fortiss.tooling.kernel.ui.internal.ContextMenuService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 6DC07C7AF82987C8C1B81DF8C2CABCEF
+ * @ConQAT.Rating YELLOW Hash: 898966F83FD7AF20C4620A8AAB017EC0
  */
-// TODO (FH): move to UI
 public interface IContextMenuService {
 
 	/** Custom menu section separator id. */

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IEditPartFactoryService.java

@@ -27,7 +27,7 @@ import org.fortiss.tooling.kernel.ui.internal.EditPartFactoryService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: A052488068BAE9406F9BEAD648E70BD7
+ * @ConQAT.Rating YELLOW Hash: F01D48DCA4F80858F39646340CE0E5F2
  */
 public interface IEditPartFactoryService extends EditPartFactory {
 

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IEditorService.java

@@ -29,7 +29,7 @@ import org.fortiss.tooling.kernel.ui.internal.EditorService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 0345494D4037310F62B12BB3806E9C77
+ * @ConQAT.Rating YELLOW Hash: 2C420A3D582F2726FBC96D141CEAEF81
  */
 public interface IEditorService {
 

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IModelElementService.java

@@ -28,7 +28,7 @@ import org.fortiss.tooling.kernel.ui.internal.ModelElementService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 4FEBCD30257311CA3D9D20F66CC2B1FA
+ * @ConQAT.Rating YELLOW Hash: 84FA1569F479C2625D09D0CA2C9A170D
  */
 public interface IModelElementService {
 

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/INavigatorService.java

@@ -29,9 +29,8 @@ import org.fortiss.tooling.kernel.ui.internal.NavigatorService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating RED Hash: 9B9DAAC0BFE14D2AE78C879E96598ED5
+ * @ConQAT.Rating YELLOW Hash: 3C201DC07138A2C1A15C710F8A81A242
  */
-// TODO (FH): move to UI
 public interface INavigatorService {
 	/** Returns the singleton instance of the service. */
 	public static final INavigatorService INSTANCE = new NavigatorService();

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IPropertiesService.java

@@ -25,7 +25,7 @@ import org.fortiss.tooling.kernel.ui.internal.PropertiesService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating RED Hash: E340ED4EFA15B122B4074F128F0A330F
+ * @ConQAT.Rating YELLOW Hash: 102C35BC9B6C4C7BFE71810750CD4D20
  */
 public interface IPropertiesService {