Code review

refs 343

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/IEclipseResourceStorageLocationProvider.java

@@ -23,20 +23,20 @@ import org.fortiss.tooling.kernel.service.IEclipseResourceStorageService;
 /**
  * Interface for providing Eclipse workspace resources as model files to the
  * kernel. This interface is usually implemented by a class of the final tool
- * product, e.g. the AF3 tool product uses <I>*.af3</I> as its model files.
+ * product, e.g. the AF3 tool product uses <I>*.af3_20</I> as its model files.
  * <P>
  * Extensions are handled by the {@link IEclipseResourceStorageService}.
  * <P>
  * The persistency storage provider, which uses Eclipse resources, does not know
- * which files should be considered model files. Therefore, a concrete product
- * built above the kernel is required to decide whether the file provided with
- * {@link #isStorageLocation(IFile)} should be considered.
+ * which files should be considered as model files. Therefore, a concrete
+ * product built above the kernel is required to decide whether the file
+ * provided with {@link #isStorageLocation(IFile)} should be considered.
  * 
  * 
  * @author hoelzlf
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating GREEN Hash: CE0537EAE8D9116253F7769DF9378FDE
+ * @ConQAT.Rating GREEN Hash: B005A67C7F154C82209F24DB2DDAD99E
  */
 public interface IEclipseResourceStorageLocationProvider {
 

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/extension/data/ITopLevelElement.java

@@ -45,9 +45,14 @@ import org.fortiss.tooling.kernel.extension.IStorageProvider;
 public interface ITopLevelElement {
 
 	/** Returns the root model element represented by this top-level element. */
+	// TODO: vielleicht wäre ne Definition, was ein Top-Level-Element und was
+	// ein Root-Element ist, nett. Es wäre auf jeden Fall hilfreich, da das
+	// keine 100% selbsterklärenden Begriffe sind.
 	EObject getRootModelElement();
 
 	/** Executes the given {@link Runnable} as model changing command. */
+	// TODO: warum model changing? Was für ein Model wird wie geändert und warum
+	// kommt das im Methodennamen nicht vor?
 	void runAsCommand(Runnable runner);
 
 	/**

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/CommandStackService.java

@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.service.IPersistencyService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 7597495197209C46729E2D1B92749E54
+ * @ConQAT.Rating GREEN Hash: 82CCE7AD2F21B0F48DBC904FF10F1C60
  */
 public class CommandStackService implements ICommandStackService {
 
@@ -89,7 +89,6 @@ public class CommandStackService implements ICommandStackService {
 	@Override
 	public void undo(EObject target) {
 		IPersistencyService.INSTANCE.getTopLevelElementFor(target).undo();
-
 	}
 
 	/** {@inheritDoc} */

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/internal/PersistencyService.java

@@ -52,7 +52,7 @@ import org.osgi.framework.Bundle;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 9BF50F6FC323A8BC88FE455D7EB05F9F
+ * @ConQAT.Rating GREEN Hash: DA27C565BD0AC1F080FAB4114C3965BD
  */
 public class PersistencyService implements IPersistencyService {
 

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/ICommandStackService.java

@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.internal.CommandStackService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 1594F25FBD1F084A4B57CA2ABAEF7851
+ * @ConQAT.Rating GREEN Hash: 4C95EE2A596AF30B31457E6C6FC6CFED
  */
 public interface ICommandStackService {
 
@@ -53,7 +53,7 @@ public interface ICommandStackService {
 	void removeCommandStackListener(ITopLevelElement target,
 			CommandStackListener listener);
 
-	/** Runs the given {@link Runnable} within a emfStore transaction. */
+	/** Runs the given {@link Runnable} within an emfStore transaction. */
 	void runAsCommand(EObject target, Runnable runner);
 
 	/** Checks if an undo command is possible on the given target's project. */

org.fortiss.tooling.kernel/trunk/src/org/fortiss/tooling/kernel/service/listener/IPersistencyServiceListener.java

@@ -28,7 +28,7 @@ import org.fortiss.tooling.kernel.extension.data.ITopLevelElement;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: B6BB618561D7DE7C3F80A60DF509564F
+ * @ConQAT.Rating GREEN Hash: CA9B2AE87CCED05A17C99E032BD98926
  */
 public interface IPersistencyServiceListener {