Issue-Ref: 3823
Issue-Url: https://af3-developer.fortiss.org/issues/3823



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3823
Issue-Url: https://af3-developer.fortiss.org/issues/3823


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3813
Issue-Url: https://af3-developer.fortiss.org/issues/3813


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* Not all IConnectors are necessarily ILayoutedModelElements

Issue-Ref: 3813
Issue-Url: https://af3-developer.fortiss.org/issues/3813



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3696
Issue-Url: https://af3-developer.fortiss.org/issues/3696


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* Enable re-use of color scheme also for other editors that embed
  annotations

Issue-Ref: 3696
Issue-Url: https://af3-developer.fortiss.org/issues/3696



Signed-off-by: Simon Barner <barner@fortiss.org>

* AccessibleObject::isAccessible() is deprecated for Java 9 and above
* Use AccessibleObject::canAccess(Object) instead
* Log a warning when the security manager denies to enable access to
  Table::setItemHeight()
* Log an error when an error occurs when trying to set the table height

Issue-Ref: 3696
Issue-Url: https://af3-developer.fortiss.org/issues/3696



Signed-off-by: Simon Barner <barner@fortiss.org>

* Dispose columns created for previous model before setting the editor
  input.
* Otherwise, the old label providers might try to access annotations
  that are not presented in the new model

Issue-Ref: 3696
Issue-Url: https://af3-developer.fortiss.org/issues/3696



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3725
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

Issue-Ref: 3709
Issue-Url: https://af3-developer.fortiss.org/issues/3709


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* Restrict input to INamedElement, only
* Add expandItem()
* Define ModelElementUIProvider as explicit (inner) type
  * Enable subclassing if needed
  * Use model element handler to obtain name

Issue-Ref: 3709
Issue-Url: https://af3-developer.fortiss.org/issues/3709



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3620
Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3482
Issue-Url: https://af3-developer.fortiss.org/issues/3482


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3482
Issue-Url: https://af3-developer.fortiss.org/issues/3482


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3657
Issue-Url: https://af3-developer.fortiss.org/issues/3657



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3620
Issue-Url: https://af3-developer.fortiss.org/issues/3620


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3620
Issue-Url: https://af3-developer.fortiss.org/issues/3620


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3482
Issue-Url: https://af3-developer.fortiss.org/issues/3482


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* Refer to the modular JDK-11 in the classpath.
* Depend on openjfx plugins from Tom Schindl.

Issue-Ref: 3620
Issue-Url: https://af3-developer.fortiss.org/issues/3620


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* Just fixed a few comments.

Issue-Ref: 3267
Issue-Url: https://af3-developer.fortiss.org/issues/3267



Signed-off-by: Marco Volpe <volpe@fortiss.org>

Issue-Ref: 3578
Issue-Url: https://af3-developer.fortiss.org/issues/3578



Signed-off-by: Marco Volpe <volpe@fortiss.org>

Issue-Ref: 3536
Issue-Url: https://af3-developer.fortiss.org/issues/3536


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3536
Signed-off-by: Sudeep Kanav <kanav@fortiss.org>

Issue-Ref: 3536
Signed-off-by: Sudeep Kanav <kanav@fortiss.org>

Issue-Ref: 3536
Signed-off-by: Sudeep Kanav <kanav@fortiss.org>

* Add new classes
  * MultiValueAnnotationTextEditingSupport, an editing support that
    allows for textual editing of multi-value annotation.
  * MultiValueAnnotationTextEditingDialog, a dialog to that allows to
    edit multiple values
* Adapt
  * EditingSupportFactory to instantiate
    MultiValueAnnotationTextEditingSupport instead of throwning an
    exception about an unsupported case
  * EStructuralFeatureValueProviderBase to set values using the new
    method setAnnotationValueFromString(Collection<String>, T)

Issue-Ref: 3578
Issue-Url: https://af3-developer.fortiss.org/issues/3578



Signed-off-by: Simon Barner <barner@fortiss.org>

* Editing support: IMultiValueAnnotationEditingSupport with base class
   MultiValueAnnotationEditingSupportBase
    * currently used in MultiValueAnnotationSelectionEditingSupport
    * integrates cell editor (whose updateData() has been dropped in
      favor of the constructor, i.e. a new cell editor is created each
      time
* Dialogs: IMultiValueAnnotationDialog with base class
  MultiValueAnnotationDialogBase
  * currently used by MultiValueAnnotationSelectionDialog

Issue-Ref: 3267
Issue-Url: https://af3-developer.fortiss.org/issues/3267



Signed-off-by: Simon Barner <barner@fortiss.org>

* Red: Namings in CustomUndoRedoForSourceEditor, SourceEditorBase.
* GREEN: annotations.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3536
Signed-off-by: Sudeep Kanav <kanav@fortiss.org>

* Retain almost all ratings ratings
* Exception: AbstractTextCellDatabindingEditingSupport, whose
  setupFieldAssist() method was removed since
   * it would have introduced a dependency to another package in
     base.ui only because is "FieldAssist" class was referenced in
     the method *comment*.
   * However, this method is only used very rarely and users of the
     class setup up their field assist in createCellEditor() instead.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

Hernan Ponce de Leon authored 6 years ago and Alexander Diewald committed 6 years ago

Issue-Ref: 3474
Signed-off-by: ponce <ponce@fortiss.org>

* Add a default dialog and handler class.
* Move the main parts of the service from the base plugin to the kernel.
* Introduce a severity enum since using int "codes" is flawed and we do
  not use underlying eclipse methods like the logging methods in the
  LoggingUtils class.

Issue-Ref: 3574
Issue-Url: https://af3-developer.fortiss.org/issues/3574


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* Intermediate review: Issue is open for the correct solution.
* Improved documentation such that developers unfamiliar with the bug
  can understand the problem more easily.

Issue-Ref: 3517
Issue-Url: https://af3-developer.fortiss.org/issues/3517


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3517
Signed-off-by: Filip Reaboi <reaboi@fortiss.org>

Issue-Ref: 3223
Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

* All clients of this class performed a type check

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

* Generalize interface to IModelElement
* Use anonymous class in GenericAnnotationView to adapt AnnotationEntry
  elements

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

* This is neither tooling.base nor UI specific
* Retain GREEN ratings since there is no change in the code (only the
  class comment has slightly been updated)

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3539
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>