* Retain almost all ratings ratings
* Exception: AbstractTextCellDatabindingEditingSupport, whose
  setupFieldAssist() method was removed since
   * it would have introduced a dependency to another package in
     base.ui only because is "FieldAssist" class was referenced in
     the method *comment*.
   * However, this method is only used very rarely and users of the
     class setup up their field assist in createCellEditor() instead.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

* setEnabled(false) in createControls() has no effect, i.e. the text
  can be edited, but the change is not saved in the model. In refresh(),
  it  would have an effect, but would "gray out" the text control
* setEditable(false) prevents the user from entering text in the
  first place.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

* org.conqat.ide.commons.ui.databinding.validate.TextToDoubleValidator
  also accepted inputs where only a prefix was valid (followed by some
  garbage)
* Local version of TextToDoubleValidator checks if the entire input was
  parsed.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3474
Signed-off-by: ponce <ponce@fortiss.org>

Issue-Ref: 3574
Issue-Url: https://af3-developer.fortiss.org/issues/3574


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Hernan Ponce de Leon authored 6 years ago and Alexander Diewald committed 6 years ago

Issue-Ref: 3474
Signed-off-by: ponce <ponce@fortiss.org>

* Add a default dialog and handler class.
* Move the main parts of the service from the base plugin to the kernel.
* Introduce a severity enum since using int "codes" is flawed and we do
  not use underlying eclipse methods like the logging methods in the
  LoggingUtils class.

Issue-Ref: 3574
Issue-Url: https://af3-developer.fortiss.org/issues/3574


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3569
Signed-off-by: ponce <ponce@fortiss.org>

* As replacement for the now deprecated
  SWTObservables.observeVisible()

Issue-Ref: 3569
Issue-Url: https://af3-developer.fortiss.org/issues/3569



Signed-off-by: Simon Barner <barner@fortiss.org>

* As replacement for the now deprecated
  SWTObservables.observeSelection()

Issue-Ref: 3569
Issue-Url: https://af3-developer.fortiss.org/issues/3569



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3223
Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* All clients of this class performed a type check

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

* Generalize interface to IModelElement
* Use anonymous class in GenericAnnotationView to adapt AnnotationEntry
  elements

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3545
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

* Return empty list instead of null on unexpected input (null or wrong
  selection type)
* Fixes NPE in setSelection()

Issue-Ref: 3545
Issue-Url: https://af3-developer.fortiss.org/issues/3545



Signed-off-by: Simon Barner <barner@fortiss.org>

* Previous GREEN rating in a57ba1f9 has
  erroneously been turned to yellow when merging

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3539
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

* Check for duplicates was based on "cstrClass" (of type Class), whereas
  the registration is based on the class name
* Note: This change does not affect the actual registration, hence no
  change in behavior is expected.
* Revealed by warning on unlikely argument of (type Class) for
  string2cstrMap.get()

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

* FontMetrics.getAverageCharWidth() has been deprecated

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

* SWTObservables is deprecated
* Add drop-in replacement of observeText() in DataBindingUtils that uses
  the new API

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3540
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

* Since migrating to Photon, the listeners of the IPersistencyService
  must be seemingly installed in the init phase. By that, the
  corresponding listeners are also aware of model loading.
* Also, remove an unneeded cast to avoid a warning.

Issue-Ref: 3540
Issue-Url: https://af3-developer.fortiss.org/issues/3540


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

* org.eclipse.jface.viewers.ViewerSorter is deprecated

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3538
Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3535
Issue-Url: https://af3-developer.fortiss.org/issues/3535


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3535
Issue-Url: https://af3-developer.fortiss.org/issues/3535



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref:3084
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

Issue-Ref: 3084
Issue-Url: https://af3-developer.fortiss.org/issues/3084



Signed-off-by: Simon Barner <barner@fortiss.org>

* If an element is already selected in the model navigator, CTRL+A
  selects all of its siblings.* This also applies for FileProjects.
* Realization
  * Add INavigatorService::setCurrentSelection()
  * SelectionUtils.setSelection() now synchronizes the selection in the
    currently active (diagram) editor and the model navigator

Issue-Ref: 3084
Issue-Url: https://af3-developer.fortiss.org/issues/3084



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3084
Issue-Url: https://af3-developer.fortiss.org/issues/3084



Signed-off-by: Simon Barner <barner@fortiss.org>

Signed-off-by: reaboi <reaboi@fortiss.org>

Issue-Ref:3514
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

* The current implementation of the IPersistencyService does not
  allow to listen for "load" or "add" events during the startup of
  AF3 whereas later events for adding and removing IToplevelElements
  are present.
* Extend the PersistencyServiceListener and the IPersistencyService
  for such a capability to enable installing listeners for model
  elements in a plugin-in fashion.

Issue-Ref: 3514
Issue-Url: https://af3-developer.fortiss.org/issues/3514


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

This reverts commit 35d7638c.

This reverts commit f6b0e5b0.

Signed-off-by: reaboi <reaboi@fortiss.org>