Skip to content
Snippets Groups Projects
  1. Jan 27, 2015
  2. Jan 23, 2015
    • Simon Barner's avatar
      - Undo last commit to NavigatorViewPart (old (partial) fix for #1491) · e24fba0f
      Simon Barner authored
      - Instead, ensure that DiagramEditorBase has the focus when a child edit part is added or removed
      - This works around #2207 and also the same part of #1491 as with the old workaround
      - Summing up:
         - Undo/redo of operations on the model only works if either the NavigatorViewPart or a DiagramEditorBase has the focus
         - This makes sense if the active view provides editable items itself (e.g., the GenericAnnotationView) *and* provides undo/redo (currently not the case for GenericAnnotationView).
         - For other (read-only) view (e.g., Model Markers), this behavior is confusing for the user
      refs 2207,1491
      e24fba0f
  3. Jan 22, 2015
    • Simon Barner's avatar
      - Move annotation value service, annotation value provider base classes and... · b351a20a
      Simon Barner authored
      - Move annotation value service, annotation value provider base classes and annotation extension point to org.foritss.tooling.base
      - Remove createEditingSupport() from IAnnotationValueProviderBase and move functionality to org.fortiss.tooling.base.ui.annotation.editingsupport.EditingSupportFactory instead
      - Rename extension point to org.fortiss.tooling.base.annotation.
      
      Example binding:
      
      <extension point="org.fortiss.tooling.base.annotation">
        <annotation binding="org.fortiss.af3.timing.annotation.valueprovider.CIValueProvider">
           <modelElementClass modelElementClass="org.fortiss.af3.component.model.Component"/>
        </annotation>
      </extension
      - Adapt all known users of annotation framework to new structure
      - The change is a preparation to fix #2208, i.e. to put the instantiation of a model element and its annotations into a single undo/redo command
      refs 2208
      
      b351a20a
  4. Jan 21, 2015
    • Simon Barner's avatar
      - Avoid case distinction in GenericAnnotationView that handles construction of... · 0d4ded58
      Simon Barner authored
      - Avoid case distinction in GenericAnnotationView that handles construction of EditingSupport for boolean annotations
      - This fixes the bug that the EditingSupport was only created correctly for derived annoations (#2225)
      - Add TODO to delegate construction of label provider to annotation value provider, too (#2226)
      refs 2225,2226
      
      0d4ded58
  5. Jan 14, 2015
  6. Jan 13, 2015
  7. Jan 12, 2015
  8. Jan 08, 2015
  9. Dec 18, 2014
  10. Dec 17, 2014
  11. Dec 16, 2014
  12. Dec 15, 2014
  13. Dec 12, 2014
  14. Dec 11, 2014
    • Simon Barner's avatar
      - Fix HierarchicalNameComparator to obey the total ordering contract of java.lang.comparable. · b3ec6f03
      Simon Barner authored
      - This should fix the related crashes that contained multiple objects with the same name
      refs 1841
      b3ec6f03
    • Simon Barner's avatar
      - Add AnnotationInstantiationMigrationProvider that augments loaded models... · df89a3e6
      Simon Barner authored
      - Add AnnotationInstantiationMigrationProvider that augments loaded models with annotations that have been added to the AF3 installation after the creation of the model.
      - Note that:
        - It is still required to use AnnotationUtils.getAnnotation() to obtain (and potentially instantiate) an annotation. This is because annotations are only instantiated for newly added model elements if the annotation view is visible.
        - IMigrationProviders that convert old attribute values into annotations cannot rely on the fact that the annotation instance already exists (since the execution order of the IMigrationProviders is not defined). Hence, the need to use AnnotationUtils.getAnnotation(modelElement, clazz, false) to obtain (and potentially instantiate) an annotation (without wrapping the model access into a command, see #2010).
      refs 1841
      
      df89a3e6
    • Simon Barner's avatar
      - Prevent nested calls of selectionChanged() which could trigger a refresh of... · 37696eb5
      Simon Barner authored
      - Prevent nested calls of selectionChanged() which could trigger a refresh of the table before all column label providers / editing support has been initialized
      refs 1841
      
      37696eb5
  15. Dec 10, 2014
    • Simon Barner's avatar
      (I)AnnotationValueService: · cb3b5ac0
      Simon Barner authored
       - List<AnnotationEntry> getValues(IModelElement element) --> AnnotationEntry getAnnotationEntry(IModelElement element);
       - The semantics of the method is change to return exactly the AnnotationEntry that contains the AnnotationValueProvider-to-IAnnotatedSpecification mapping for the given model element. In the old semantics, a list of all annotation entries for model elements that had the same type as the given model element have been returned.
      
      AnnotationEntry:
       - add isEmpty()
      
      Consequences:
       - Fix update bug of GenericAnnotationView when deleting model elements (stale rows used to stay in the view)
       - Performance improvement
      
      TODO: The GenericAnnotationView is still very slow during the deletion of large sub-models (and probably also during addition e.g., because of c'n'p of large sub-models) 
      refs 1841
      cb3b5ac0
  16. Dec 04, 2014
Loading