- Jan 27, 2015
-
-
Simon Barner authored
- Prevent multiple fan-in for IHierarchicElement -> IConnector connections (was erroneously enabled in some cases) - If this is desired, concrete compositors should override canConnectInterally() refs 2233
-
- Jan 23, 2015
-
-
Simon Barner authored
- Instead, ensure that DiagramEditorBase has the focus when a child edit part is added or removed - This works around #2207 and also the same part of #1491 as with the old workaround - Summing up: - Undo/redo of operations on the model only works if either the NavigatorViewPart or a DiagramEditorBase has the focus - This makes sense if the active view provides editable items itself (e.g., the GenericAnnotationView) *and* provides undo/redo (currently not the case for GenericAnnotationView). - For other (read-only) view (e.g., Model Markers), this behavior is confusing for the user refs 2207,1491
-
- Jan 22, 2015
-
-
Simon Barner authored
- Move annotation value service, annotation value provider base classes and annotation extension point to org.foritss.tooling.base - Remove createEditingSupport() from IAnnotationValueProviderBase and move functionality to org.fortiss.tooling.base.ui.annotation.editingsupport.EditingSupportFactory instead - Rename extension point to org.fortiss.tooling.base.annotation. Example binding: <extension point="org.fortiss.tooling.base.annotation"> <annotation binding="org.fortiss.af3.timing.annotation.valueprovider.CIValueProvider"> <modelElementClass modelElementClass="org.fortiss.af3.component.model.Component"/> </annotation> </extension - Adapt all known users of annotation framework to new structure - The change is a preparation to fix #2208, i.e. to put the instantiation of a model element and its annotations into a single undo/redo command refs 2208
-
- Jan 21, 2015
-
-
Simon Barner authored
- Avoid case distinction in GenericAnnotationView that handles construction of EditingSupport for boolean annotations - This fixes the bug that the EditingSupport was only created correctly for derived annoations (#2225) - Add TODO to delegate construction of label provider to annotation value provider, too (#2226) refs 2225,2226
-
- Jan 14, 2015
-
-
Simon Barner authored
- Fix crash in some annotation value providers during undo/redo by checking if annotation specifications are registered with a model element refs 2204
-
Vincent Aravantinos authored
refs 2133
-
- Jan 13, 2015
-
-
Simon Barner authored
- If the annotations view is not visible (i.e., not opened at all, or not the active tab), create and raise the properties view - Otherwise, just create the properties view, but do not raise it (the annotation view acts as a replacement for many properties) refs 2133
-
Simon Barner authored
- Change view ID to "org.fortiss.tooling.base.ui.annotationView" and define a Java String constant for it refs 2133,1841
-
Simon Barner authored
- Eliminate superfluous override of performRequest() because of the inheritance relation: ConnectorEditPartBase -> PositionedEditPartBase -> GraphicalEditPartBase - GraphicalEditPartBase provides the desired functionality to raise the properties view, and PositionedEditPartBase does not override this behavior refs 2133
-
Simon Barner authored
- No functional change refs 2133
-
- Jan 12, 2015
-
-
Simon Barner authored
refs 2189,1841
-
Simon Barner authored
refs 2189,1841
-
- Jan 08, 2015
-
-
Simon Barner authored
refs 1841
-
Simon Barner authored
- Install EAdapter for top level element of current project (instead of switching it the currently active root element (e.g., component architecture)). - This ensures that annotation views are updated also on changes of models that currently do not have the focus (i.e. programmatic changes of models that are currently not shown in the diagram view) refs 1841
-
Simon Barner authored
- Display model element ID in tooltip (in addition to model element name). This is useful to identify selection targets for annotations of type EReference where the editor also displays the ID in order to distinguish elements with the same name. refs 1841
-
- Dec 18, 2014
-
-
Simon Barner authored
- Add isAvailableObject() method that can be overridden by value providers in order to filter the set of available elements LabelValueMapping: Use this filter refs 1841
-
Simon Barner authored
refs 1841
-
- Dec 17, 2014
-
-
Simon Barner authored
- TextEditingSupport / ElementEditingSupportBase: Unset value if users enters the empty string refs 1841
-
Alexander Diewald authored
Modify the DerivedAnnotationValueProvider (org.fortiss.tooling.base.ui), such that the editability of the annotation editing support mirrors the behavior of the derived annotation.
-
- Dec 16, 2014
-
-
Simon Barner authored
- Remove support for multiple selections of values since it is not supported by EMF which enforces that the lists used to implement features with multiplicity > 1 are unique: <https://www.eclipse.org/forums/index.php?t=msg&th=133621&goto=417016&#msg_417016> refs 1841
-
Simon Barner authored
refs 1841
-
Simon Barner authored
refs 1841
-
Simon Barner authored
- Support to select an element more than once (enabled by default). In order to disable this feature, use the map-based constructor of EStructuralFeatureValueProviderBase and construct the EStructuralFeature accordingly. - Fix update of Ok button when deselecting all elements (fire second event to work around bug in DualList base class) refs 1841
-
Simon Barner authored
refs 1841
-
Simon Barner authored
refs 1841
-
Simon Barner authored
refs 1841
-
Simon Barner authored
- Do not cache LabelValueMapping since {@link IDerivedAnnotation}s support that the {@link {EStructuralFeature} of their return value is changed at runtime refs 1841
-
Simon Barner authored
refs 1841
-
Simon Barner authored
refs 1841
-
- Dec 15, 2014
-
-
Simon Barner authored
refs 1841
-
Simon Barner authored
- Do not expose createComboBoxLabelValueMapping() - Instead, provide getLabel() refs 1841
-
Simon Barner authored
- Implement MultiSelectionEditing support that currently supports the selection of multiple values for EReferences (based on OPAL's DualList) - Rename ComboBoxLabelValue mapping -> LabelValueMapping - Update AnnotationViewPartBase also on ADD_MANY / REMOVE_MANY events refs 1841
-
- Dec 12, 2014
-
-
Simon Barner authored
- Add private getAnnotationValueProvider() method refs 1841
-
Simon Barner authored
- Remove getEStructuralFeatureOf() - Expose DEFAULT_KEY (from AnnotationValueProviderBase) - createEditingSupport(): Pass current specification - AnnotationEntry: - Remove getSpecificationElementFeature() - Add getSpecification(). TODO: Use this method internally in AnnotationEntry - EStructuralFeatureDescriptor - getEStructuralFeature(): Pass current specification - Base on the above, no longer base logic to compute the currently active EStructuralFeature for IDerivedAnnotiations on a temporary EStructuralFeatureDescriptor refs 1841
-
Alexander Diewald authored
refs 2171
-
- Dec 11, 2014
-
-
Simon Barner authored
- This should fix the related crashes that contained multiple objects with the same name refs 1841
-
Simon Barner authored
- Add AnnotationInstantiationMigrationProvider that augments loaded models with annotations that have been added to the AF3 installation after the creation of the model. - Note that: - It is still required to use AnnotationUtils.getAnnotation() to obtain (and potentially instantiate) an annotation. This is because annotations are only instantiated for newly added model elements if the annotation view is visible. - IMigrationProviders that convert old attribute values into annotations cannot rely on the fact that the annotation instance already exists (since the execution order of the IMigrationProviders is not defined). Hence, the need to use AnnotationUtils.getAnnotation(modelElement, clazz, false) to obtain (and potentially instantiate) an annotation (without wrapping the model access into a command, see #2010). refs 1841
-
Simon Barner authored
- Prevent nested calls of selectionChanged() which could trigger a refresh of the table before all column label providers / editing support has been initialized refs 1841
-
- Dec 10, 2014
-
-
Simon Barner authored
- List<AnnotationEntry> getValues(IModelElement element) --> AnnotationEntry getAnnotationEntry(IModelElement element); - The semantics of the method is change to return exactly the AnnotationEntry that contains the AnnotationValueProvider-to-IAnnotatedSpecification mapping for the given model element. In the old semantics, a list of all annotation entries for model elements that had the same type as the given model element have been returned. AnnotationEntry: - add isEmpty() Consequences: - Fix update bug of GenericAnnotationView when deleting model elements (stale rows used to stay in the view) - Performance improvement TODO: The GenericAnnotationView is still very slow during the deletion of large sub-models (and probably also during addition e.g., because of c'n'p of large sub-models) refs 1841
-
- Dec 04, 2014
-
-
Simon Barner authored
- Remove redundant dependencies (i.e., those, that are already contained and re-exported by the actual dependencies)
-