- Instead, ensure that DiagramEditorBase has the focus when a child edit part is added or removed
- This works around #2207 and also the same part of #1491 as with the old workaround
- Summing up:
   - Undo/redo of operations on the model only works if either the NavigatorViewPart or a DiagramEditorBase has the focus
   - This makes sense if the active view provides editable items itself (e.g., the GenericAnnotationView) *and* provides undo/redo (currently not the case for GenericAnnotationView).
   - For other (read-only) view (e.g., Model Markers), this behavior is confusing for the user
refs 2207,1491

- Fix addition of spurious undo/redo command by ensuring that annotations are instantiated from HierarchicElementCompositorBase.compose()
- Derived compositors that override compose() must ensure that call their parent classes' implementation
refs 2208

- Move annotation value service, annotation value provider base classes and annotation extension point to org.foritss.tooling.base
- Remove createEditingSupport() from IAnnotationValueProviderBase and move functionality to org.fortiss.tooling.base.ui.annotation.editingsupport.EditingSupportFactory instead
- Rename extension point to org.fortiss.tooling.base.annotation.

Example binding:

<extension point="org.fortiss.tooling.base.annotation">
  <annotation binding="org.fortiss.af3.timing.annotation.valueprovider.CIValueProvider">
     <modelElementClass modelElementClass="org.fortiss.af3.component.model.Component"/>
  </annotation>
</extension
- Adapt all known users of annotation framework to new structure
- The change is a preparation to fix #2208, i.e. to put the instantiation of a model element and its annotations into a single undo/redo command
refs 2208

- Avoid case distinction in GenericAnnotationView that handles construction of EditingSupport for boolean annotations
- This fixes the bug that the EditingSupport was only created correctly for derived annoations (#2225)
- Add TODO to delegate construction of label provider to annotation value provider, too (#2226)
refs 2225,2226

refs 1491

- Fix crash in some annotation value providers during undo/redo by checking if annotation specifications are registered with a model element
refs 2204

refs 2133

- Document that getAnnotation(IModelElement modelElement, Class<T> clazz) wraps the model access into a command
refs 2199,1841

- Ensure that that AnnotationsUtils.getAnnotation(IModelElement modelElement, Class<T> clazz)  actually wraps the extraction / creation of an annotation into a command
- DAGExtractionWithoutDeployment: use this variant
refs 2199,1841

- If the annotations view is not visible (i.e., not opened at all, or not the active tab), create and raise the properties view
- Otherwise, just create the properties view, but do not raise it (the annotation view acts as a replacement for many properties)
refs 2133

- Change view ID to "org.fortiss.tooling.base.ui.annotationView" and define a Java String constant for it
refs 2133,1841

- Eliminate superfluous override of performRequest() because of the inheritance relation: ConnectorEditPartBase -> PositionedEditPartBase -> GraphicalEditPartBase
- GraphicalEditPartBase provides the desired functionality to raise the properties view, and PositionedEditPartBase does not override this behavior
refs 2133

- No functional change
refs 2133

refs 2189,1841

refs 2189,1841

refs 1841

- Install EAdapter for top level element of current project (instead of switching it the currently active root element (e.g., component architecture)).
- This ensures that annotation views are updated also on changes of models that currently do not have the focus (i.e. programmatic changes of models that are currently not shown in the diagram view)
refs 1841

- Display model element ID in tooltip (in addition to model element name). This is useful to identify selection targets for annotations of type EReference where the editor also displays the ID in order to distinguish elements with the same name.
refs 1841

- Add isAvailableObject() method that can be overridden by value providers in order to filter the set of available elements

LabelValueMapping: Use this filter
refs 1841

refs 1841

- TextEditingSupport / ElementEditingSupportBase: Unset value if users enters the empty string
refs 1841

Modify the DerivedAnnotationValueProvider (org.fortiss.tooling.base.ui), such that the editability of the annotation editing support mirrors the behavior of the derived annotation.

- Remove support for multiple selections of values since it is not supported by EMF which enforces that the lists used to implement features with multiplicity > 1 are unique:

<https://www.eclipse.org/forums/index.php?t=msg&th=133621&goto=417016&#msg_417016>

refs 1841

refs 1841

refs 1841

- Support to select an element more than once (enabled by default). In order to disable this feature, use the map-based constructor of EStructuralFeatureValueProviderBase and construct the EStructuralFeature accordingly.
- Fix update of Ok button when deselecting all elements (fire second event to work around bug in DualList base class)
refs 1841

refs 1841

refs 1841

refs 1841

- Do not cache LabelValueMapping since {@link IDerivedAnnotation}s support that the {@link {EStructuralFeature} of their return value is changed at runtime
refs 1841

refs 1841

refs 1841

refs 1841

- Do not expose createComboBoxLabelValueMapping()
- Instead, provide getLabel()
refs 1841

- Implement MultiSelectionEditing support that currently supports the selection of multiple values for EReferences (based on OPAL's DualList)
- Rename ComboBoxLabelValue mapping -> LabelValueMapping
- Update AnnotationViewPartBase also on ADD_MANY / REMOVE_MANY events
refs 1841

- Add private getAnnotationValueProvider() method
refs 1841

  - Remove getEStructuralFeatureOf()
  - Expose DEFAULT_KEY (from AnnotationValueProviderBase)
  - createEditingSupport(): Pass current specification

- AnnotationEntry:
  - Remove getSpecificationElementFeature()
  - Add getSpecification(). TODO: Use this method internally in AnnotationEntry
  
- EStructuralFeatureDescriptor
  - getEStructuralFeature(): Pass current specification
  
- Base on the above, no longer base logic to compute the currently active EStructuralFeature for IDerivedAnnotiations on a temporary EStructuralFeatureDescriptor
refs 1841

- Adjust all annotations that inherited from IDerivedAnnotation to use the new DerivedAnnotationBase class
- EOperation cleanup
- Move getValue() from org.fortiss.tooling.base.utils.AnnotationUtils to org.fortiss.tooling.base.model.base.impl.DerivedAnnotationBaseStaticImpl

refs 2171

- This should fix the related crashes that contained multiple objects with the same name
refs 1841