Issue-Ref: 3578
Issue-Url: https://af3-developer.fortiss.org/issues/3578



Signed-off-by: Marco Volpe <volpe@fortiss.org>

Issue-Ref: 3536
Issue-Url: https://af3-developer.fortiss.org/issues/3536


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3536
Signed-off-by: Sudeep Kanav <kanav@fortiss.org>

Issue-Ref: 3536
Signed-off-by: Sudeep Kanav <kanav@fortiss.org>

Issue-Ref: 3536
Signed-off-by: Sudeep Kanav <kanav@fortiss.org>

* Add new classes
  * MultiValueAnnotationTextEditingSupport, an editing support that
    allows for textual editing of multi-value annotation.
  * MultiValueAnnotationTextEditingDialog, a dialog to that allows to
    edit multiple values
* Adapt
  * EditingSupportFactory to instantiate
    MultiValueAnnotationTextEditingSupport instead of throwning an
    exception about an unsupported case
  * EStructuralFeatureValueProviderBase to set values using the new
    method setAnnotationValueFromString(Collection<String>, T)

Issue-Ref: 3578
Issue-Url: https://af3-developer.fortiss.org/issues/3578



Signed-off-by: Simon Barner <barner@fortiss.org>

* Editing support: IMultiValueAnnotationEditingSupport with base class
   MultiValueAnnotationEditingSupportBase
    * currently used in MultiValueAnnotationSelectionEditingSupport
    * integrates cell editor (whose updateData() has been dropped in
      favor of the constructor, i.e. a new cell editor is created each
      time
* Dialogs: IMultiValueAnnotationDialog with base class
  MultiValueAnnotationDialogBase
  * currently used by MultiValueAnnotationSelectionDialog

Issue-Ref: 3267
Issue-Url: https://af3-developer.fortiss.org/issues/3267



Signed-off-by: Simon Barner <barner@fortiss.org>

* Red: Namings in CustomUndoRedoForSourceEditor, SourceEditorBase.
* GREEN: annotations.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3536
Signed-off-by: Sudeep Kanav <kanav@fortiss.org>

* Retain almost all ratings ratings
* Exception: AbstractTextCellDatabindingEditingSupport, whose
  setupFieldAssist() method was removed since
   * it would have introduced a dependency to another package in
     base.ui only because is "FieldAssist" class was referenced in
     the method *comment*.
   * However, this method is only used very rarely and users of the
     class setup up their field assist in createCellEditor() instead.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

Hernan Ponce de Leon authored 6 years ago and Alexander Diewald committed 6 years ago

Issue-Ref: 3474
Signed-off-by: ponce <ponce@fortiss.org>

* Add a default dialog and handler class.
* Move the main parts of the service from the base plugin to the kernel.
* Introduce a severity enum since using int "codes" is flawed and we do
  not use underlying eclipse methods like the logging methods in the
  LoggingUtils class.

Issue-Ref: 3574
Issue-Url: https://af3-developer.fortiss.org/issues/3574


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* Intermediate review: Issue is open for the correct solution.
* Improved documentation such that developers unfamiliar with the bug
  can understand the problem more easily.

Issue-Ref: 3517
Issue-Url: https://af3-developer.fortiss.org/issues/3517


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3517
Signed-off-by: Filip Reaboi <reaboi@fortiss.org>

Issue-Ref: 3223
Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

* All clients of this class performed a type check

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

* Generalize interface to IModelElement
* Use anonymous class in GenericAnnotationView to adapt AnnotationEntry
  elements

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

* This is neither tooling.base nor UI specific
* Retain GREEN ratings since there is no change in the code (only the
  class comment has slightly been updated)

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3539
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

* org.eclipse.jface.viewers.ViewerSorter is deprecated

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3538
Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref:3084
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

Issue-Ref: 3084
Issue-Url: https://af3-developer.fortiss.org/issues/3084



Signed-off-by: Simon Barner <barner@fortiss.org>

Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

* Also preserved in issue in case it should be needed again

Issue-Ref: 3381
Issue-Url: https://af3-developer.fortiss.org/issues/3381



Signed-off-by: Simon Barner <barner@fortiss.org>

Signed-off-by: reaboi <reaboi@fortiss.org>

Issue-Ref:3514
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

* The current implementation of the IPersistencyService does not
  allow to listen for "load" or "add" events during the startup of
  AF3 whereas later events for adding and removing IToplevelElements
  are present.
* Extend the PersistencyServiceListener and the IPersistencyService
  for such a capability to enable installing listeners for model
  elements in a plugin-in fashion.

Issue-Ref: 3514
Issue-Url: https://af3-developer.fortiss.org/issues/3514


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Signed-off-by: Florian Hoelzl <hoelzl@fortiss.org>

Issue-Ref:3401

Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

Issue-Ref: 3401
Issue-Url: https://af3-developer.fortiss.org/issues/3401



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref:3433
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

* Remove messy (and unneeded) loop to wait until the editor has
  opened
* Style cleanup

Issue-Ref: 3433
Issue-Url: https://af3-developer.fortiss.org/issues/3433


Signed-off-by: Simon Barner <barner@fortiss.org>

* No longer use erroneous heuristics that depends on the assumption that
  for some model viewst there is a hidden root element (e.g., CA)
* Instead, use the model element handler service to determine object
  to be edited (same as object to be layouted).

Issue-Ref: 3433
Issue-Url: https://af3-developer.fortiss.org/issues/3433


Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3433
Issue-Url: https://af3-developer.fortiss.org/issues/3433



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3433
Issue-Url: https://af3-developer.fortiss.org/issues/3433



Signed-off-by: Simon Barner <barner@fortiss.org>