3539 (!27) · Merge requests · af3 / kernel

Merged Simon Barner requested to merge 3539 into master 6 years ago

Oct 04, 2018

GREEN · 69d5cc89

Simon Barner authored 6 years ago

* Previous GREEN rating in a57ba1f9 has
  erroneously been turned to yellow when merging

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

69d5cc89

Review: mostly GREEN · ec7e102a
Hernan Ponce de Leon authored 6 years ago
```
Issue-Ref: 3539
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>
```
ec7e102a

Use try-with-resources to prevent potential resource leaks · ef3ad32e

Simon Barner authored 6 years ago

* Detected by enabling all resource-related Java compiler warnings
 * Java -> Compiler -> Errors/Warnings
 * Filtering for "resource" should show 3 warnings
 * Set to "Warning"

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

ef3ad32e

Merge branch 'master' of https://git.fortiss.org/af3/kernel.git into 3539 · c7cca376

Simon Barner authored 6 years ago

Conflicts:
	org.fortiss.tooling.kernel.ui/src/org/fortiss/tooling/kernel/ui/internal/.ratings

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

c7cca376

registerConstraintUI(): Fix check for duplicate UI registrations · e5008af8

Simon Barner authored 6 years ago

* Check for duplicates was based on "cstrClass" (of type Class), whereas
  the registration is based on the class name
* Note: This change does not affect the actual registration, hence no
  change in behavior is expected.
* Revealed by warning on unlikely argument of (type Class) for
  string2cstrMap.get()

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

e5008af8

FontMetrics.getAverageCharWidth() -> getAverageCharacterWidth() · 7995b049

Simon Barner authored 6 years ago

* FontMetrics.getAverageCharWidth() has been deprecated

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

7995b049

Avoid warning about raw type · 63372ad7

Simon Barner authored 6 years ago

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

63372ad7

SWTObservables.observeText() -> DataBindingUtils.observeText() · f6aed7e5

Simon Barner authored 6 years ago

* SWTObservables is deprecated
* Add drop-in replacement of observeText() in DataBindingUtils that uses
  the new API

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

f6aed7e5

Avoid warning about unlikely argument · c2c021b5

Simon Barner authored 6 years ago

* container.getContainedElements() is of type List<IHierarchicElement>
* The (unchecked) cast of elementRef -> IHierarchicElement has already
  been present in the previous version of this method

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

c2c021b5

Avoid warnings about unchecked casts · 4653cf4d

Simon Barner authored 6 years ago

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

4653cf4d

Oct 02, 2018

Remove unnecessary casts · 5e2d9c9d

Simon Barner authored 6 years ago

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

5e2d9c9d

IObservable*: Avoid using raw types · 046f8788

Simon Barner authored 6 years ago

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

046f8788

Remove references to pom.xml · 83e8386b

Simon Barner authored 6 years ago

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

83e8386b

Use org.eclipse.jface.viewers.ViewerComparator instead of ViewerSorter · 8cbf3a74

Simon Barner authored 6 years ago

* org.eclipse.jface.viewers.ViewerSorter is deprecated

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

8cbf3a74

3539

Merge request reports

Activity