3209 javafx

Companion MR. Please see af3!26 (merged)

added 2 commits

• 6e6b0f32 - GREEN
• 6d8eef7c - GREEN

Compare with previous version

added Code-Reviewed label

assigned to @ponce

assigned to @diewald

assigned to @eder

There is a RED file (AnnotationUtils) which is correct since there are some TODOs. However it seems that those TODOs are not related with this issue. If you confirm the rest of the code has been reviewed, I can merge even if the class is RED

I just talked with Alex and he told me the class can be marked as GREEN. So I'm merging it

added 1 commit

• c69a8a57 - GREEN

Compare with previous version

merged

mentioned in commit e772c1ef

Ok. So can I close the issue now, or what is the process?

Mark it as resolved, assign it to me and I'll close it

The issue in redmine should be solved by the master. I forgot to set it to resolved... :(

And you close this merge request, too?

Merging closes a Merge Request. The redmine issue is "independent" in that sense and more oriented at management than implementation. From a redmine perspective you don't "see" the different repos :)

Ah ok thanks;)

I was just wondering because I can still push the 'Close Merge Request' Button at the top of this page.

assigned to @diewald

Hmm, I'm not able to do so. Maybe a caching issue?