Skip to content
Snippets Groups Projects
Commit 25dd9531 authored by Alexander Diewald's avatar Alexander Diewald
Browse files

Code Review: GREEN

* Intermediate review: Issue is open for the correct solution.
* Improved documentation such that developers unfamiliar with the bug
  can understand the problem more easily.

Issue-Ref: 3517
Issue-Url: https://af3-developer.fortiss.org/issues/3517


Signed-off-by: default avatarAlexander Diewald <diewald@fortiss.org>
parent ad3a2b9b
No related branches found
No related tags found
1 merge request!313517 Graphical glitch with states
DiagramLayoutConfigurationBase.java a2fdf000358081429b80706bf29ad6eeda056c2b GREEN DiagramLayoutConfigurationBase.java a2fdf000358081429b80706bf29ad6eeda056c2b GREEN
EllipseCurveLayoutDiagramConfiguration.java a7525b252cd5b92549952a81dbb84e646550ebee YELLOW EllipseCurveLayoutDiagramConfiguration.java c829b7b82c062a96f8e0c76f78b49ff05b4ddaa2 GREEN
IDiagramLayoutConfiguration.java 2c05b73b104fcea91ad3505ae255e014c314685c GREEN IDiagramLayoutConfiguration.java 2c05b73b104fcea91ad3505ae255e014c314685c GREEN
RectangleGridLayoutDiagramConfiguration.java 23ddf57d202057181c150bd8c8b6df972b762522 GREEN RectangleGridLayoutDiagramConfiguration.java 23ddf57d202057181c150bd8c8b6df972b762522 GREEN
...@@ -125,10 +125,11 @@ public class EllipseCurveLayoutDiagramConfiguration extends DiagramLayoutConfigu ...@@ -125,10 +125,11 @@ public class EllipseCurveLayoutDiagramConfiguration extends DiagramLayoutConfigu
// update move delta with new position // update move delta with new position
newPosition.translate(newPosition.getDifference(oldPosition)); newPosition.translate(newPosition.getDifference(oldPosition));
// TODO FR (see #3517). The moveData seems not to be correctly calculated and one // TODO FR (see #3517). The moveData is not correctly calculated. The projected location
// could not found a solution for its calculation yet. The "ghost" cursor should // should move on the ellipse border, the same as on a rectangular border. As of now the
// move on the ellipse border, the same as on a rectangular border. It can be used // projection is also placed outside and inside the ellipse.
// like this till a solution will be found. // Until the calculation code is fixed, do not apply the result such that these connectors
// are at least moveable all around the ellipse.
// request.setMoveDelta(new Point(newPosition.getX(), newPosition.getY())); // request.setMoveDelta(new Point(newPosition.getX(), newPosition.getY()));
} }
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment