Skip to content
Snippets Groups Projects
Commit 2cc9b701 authored by Daniel Ratiu's avatar Daniel Ratiu
Browse files

another code review iteration is performed

parent 396367d8
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
Showing
with 24 additions and 18 deletions
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/ToolingKernelUIActivator.java
+ 1
− 1
View file @ 2cc9b701
......@@ -27,7 +27,7 @@ import org.osgi.framework.BundleContext;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 1BDD065B5C8C0E977D45B5BB2D6AD704
* @ConQAT.Rating GREEN Hash: 5821A4A0D157C68F2D26739DAD86CA9A
*/
public class ToolingKernelUIActivator extends AbstractUIPlugin {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/base/package.html
+ 1
− 1
View file @ 2cc9b701
<!--
$Id$
@version $Rev$
@ConQAT.Rating YELLOW Hash: 8DA8330C731AF1130EEDFAF1CAE4CE2E
@ConQAT.Rating GREEN Hash: B7912AFB4649A41D402C92E20A4A7412
-->
<body>
Abstract base implementations for the kernel UI extensions.
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IActionContributingEditor.java
+ 1
− 1
View file @ 2cc9b701
......@@ -27,7 +27,7 @@ import org.fortiss.tooling.kernel.ui.internal.editor.BindingContributor;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 4644FCF70CA34FD1D20CFB174FD4E4A4
* @ConQAT.Rating GREEN Hash: E446C6AAF3BA8D6D004F10F3936EAD75
*/
public interface IActionContributingEditor {
/**
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IBindingEditorPageChangeListener.java
+ 1
− 1
View file @ 2cc9b701
......@@ -25,7 +25,7 @@ import org.fortiss.tooling.kernel.ui.internal.editor.BindingEditor;
* @author hoelzl
* @author $Author: hoelzl $
* @version $Rev: 18709 $
* @ConQAT.Rating YELLOW Hash: 31B6B4FCCD19160ADF8A9ACBD31B3E9B
* @ConQAT.Rating GREEN Hash: 912F8EC4536E910BB229CF9867FA0A63
*/
public interface IBindingEditorPageChangeListener {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/ICustomMenuContributor.java
+ 1
− 1
View file @ 2cc9b701
......@@ -29,7 +29,7 @@ import org.fortiss.tooling.kernel.ui.services.IContextMenuService;
* @author hoelzlf
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 08A60D2BBA490E7EBB63F2F6B02983C9
* @ConQAT.Rating GREEN Hash: 38606F3B8E5D282EEB2669C7C458110B
*/
public interface ICustomMenuContributor {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/IEditPartFactory.java
+ 1
− 1
View file @ 2cc9b701
......@@ -30,7 +30,7 @@ import org.fortiss.tooling.kernel.interfaces.IEObjectAware;
* @author hoelzlf
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: E20E3FBA08256173AF0B9538151BB880
* @ConQAT.Rating GREEN Hash: 92C6AEF3682C444DF19067D99C1071F0
*/
public interface IEditPartFactory<T extends EObject> extends IEObjectAware<T>,
EditPartFactory {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/interfaces/package.html
+ 1
− 0
View file @ 2cc9b701
......@@ -5,4 +5,5 @@
-->
<body>
Interface definitions for extension classes of kernel UI extension points.
@TODO: are all these interfaces corresponding to an extension point?
</body>
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/EditPartFactoryService.java
+ 1
− 1
View file @ 2cc9b701
......@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.util.LoggingUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: F3AF21797C779669598761DD4854D145
* @ConQAT.Rating GREEN Hash: 8779DDD08371F49DCFB04FF0515A5349
*/
public class EditPartFactoryService extends
EObjectAwareServiceBase<IEditPartFactory<EObject>> implements
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/ModelElementService.java
+ 1
− 1
View file @ 2cc9b701
......@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.ui.services.IModelElementService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 9D99C615FF981BE0831593DC3600D498
* @ConQAT.Rating GREEN Hash: F9743B1AB08AF0404BB9B421F8103BC3
*/
public class ModelElementService extends
EObjectAwareServiceBase<IModelElementHandler<EObject>> implements
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/NavigatorService.java
+ 1
− 1
View file @ 2cc9b701
......@@ -46,7 +46,7 @@ import org.fortiss.tooling.kernel.ui.util.EObjectSelectionUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: FB5662C65C21DF94B8E8D3C1F25DC679
* @ConQAT.Rating GREEN Hash: 49F7CC4408BA44565132406035534C8A
*/
public class NavigatorService implements INavigatorService,
ITopLevelElementChangeListener, CommandStackListener {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/PropertiesService.java
+ 1
− 1
View file @ 2cc9b701
......@@ -25,7 +25,7 @@ import org.fortiss.tooling.kernel.ui.services.IPropertiesService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 37CDABB5D03E1D2F534D83EB55855351
* @ConQAT.Rating GREEN Hash: F8F54E850FEB15FACC2A9CE2CF8354AB
*
*/
public class PropertiesService implements IPropertiesService {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/BindingContributor.java
+ 3
− 1
View file @ 2cc9b701
......@@ -31,7 +31,7 @@ import org.fortiss.tooling.kernel.ui.services.IActionService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: C7051BC810281AFB5BA9B19154724151
* @ConQAT.Rating GREEN Hash: B6C60CD2A8A605CD9533DBF968D06721
*/
public final class BindingContributor extends
MultiPageEditorActionBarContributor {
......@@ -46,6 +46,8 @@ public final class BindingContributor extends
*/
@Override
public void setActiveEditor(IEditorPart part) {
// TODO: the text message from below is false - we do not have CCTS
// anymore
CCSMPre.isTrue(part instanceof BindingEditor,
"This contributor may only be used for CCTSBindingEditors!");
IActionService.INSTANCE.registerGlobalActions(getActionBars());
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/BindingEditor.java
+ 3
− 0
View file @ 2cc9b701
......@@ -46,6 +46,9 @@ import org.fortiss.tooling.kernel.ui.services.IPropertiesService;
* This editor is used for displaying multiple editors provided by editor
* bindings for a given model element.
*
* TODO: the name "Binding" is unintuitive to me. + is there a link to
* IEditorBinding?
*
* @author hoelzlf
* @author $Author$
* @version $Rev$
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/ModelElementEditorInput.java
+ 1
− 1
View file @ 2cc9b701
......@@ -30,7 +30,7 @@ import org.fortiss.tooling.kernel.ui.services.IModelElementService;
* @author hoelzlf
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 97D91D2A7C2890305CC4A990F1A5FBC1
* @ConQAT.Rating GREEN Hash: 5F6A0DEC72D481619982ECF12E160595
*/
public final class ModelElementEditorInput implements IEditorInput {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/editor/package.html
+ 1
− 1
View file @ 2cc9b701
<!--
$Id$
@version $Rev$
@ConQAT.Rating YELLOW Hash: 99E18C3CEA9C878B34F6AE4CC04AD9DE
@ConQAT.Rating GREEN Hash: F14CE26F84629DFAA80E133DBE28A5E8
-->
<body>
Implementations of the multi-page binding editor provided by the kernel user-interface.
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/package.html
+ 1
− 1
View file @ 2cc9b701
<!--
$Id$
@version $Rev$
@ConQAT.Rating YELLOW Hash: DEE82E65C55976C18489848C51FF6CCB
@ConQAT.Rating GREEN Hash: F83081A294B439073D0B6C695C634349
-->
<body>
Implementations of the user-interface kernel services defined in the <code>kernel.ui.services</code> package.
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/IdLabeledPropertySection.java
+ 1
− 1
View file @ 2cc9b701
......@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.ui.databinding.Observables;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: AAF40E2ED1B53B1E58814F6BB5A710D4
* @ConQAT.Rating GREEN Hash: 73C7C020F3B07C168D20AB9711428AB2
*/
public class IdLabeledPropertySection extends PropertySectionBase {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/NamedCommentedPropertySection.java
+ 1
− 1
View file @ 2cc9b701
......@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.ui.databinding.Observables;
* @author ratiu
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 94D36327BAB4EA717EA2163D820B9194
* @ConQAT.Rating GREEN Hash: 5390821E87E9BDA0439B8B19B33AB08F
*/
public class NamedCommentedPropertySection extends PropertySectionBase {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/PropertiesAdapterFactory.java
+ 1
− 1
View file @ 2cc9b701
......@@ -29,7 +29,7 @@ import org.fortiss.tooling.kernel.ui.services.IPropertiesService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 0CB9AF7EAB134DF256A41CEDF2C4FE44
* @ConQAT.Rating GREEN Hash: 25908F042E789FA56F43A853A8B1973B
*/
@SuppressWarnings("rawtypes")
public final class PropertiesAdapterFactory implements IAdapterFactory {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/properties/package.html
+ 1
− 1
View file @ 2cc9b701
<!--
$Id$
@version $Rev$
@ConQAT.Rating YELLOW Hash: 931E710E39C8E7200A075D99678564FF
@ConQAT.Rating GREEN Hash: 5D4ABF80310EC18886A1F3E311843798
-->
<body>
Implementations of the default property sections provided by the kernel.
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment