kernel.ui review

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/CompositionServiceLocalCopyPasteTransfer.java

@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.service.IElementCompositorService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C4A39BE50B2BEFAF5F14754943920C1A
+ * @ConQAT.Rating GREEN Hash: FF31D6F7A71D2A2CE37F7ABE2EAFA593
  */
 public class CompositionServiceLocalCopyPasteTransfer extends
 		SimpleObjectTransfer {

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/CompositionServiceLocalDNDTransfer.java

@@ -33,7 +33,7 @@ import org.fortiss.tooling.kernel.service.IElementCompositorService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 5169C8BD6F5DFB37A4FAB9C70E309861
+ * @ConQAT.Rating GREEN Hash: 3FBAB8464E7ECE8B69F3B49168EB7E21
  */
 public class CompositionServiceLocalDNDTransfer extends SimpleObjectTransfer {
 	/** Singleton instance. */

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDragSourceAdapter.java

@@ -35,7 +35,7 @@ import org.eclipse.swt.dnd.DragSourceAdapter;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: BC296AB36683BA41596609D5F1C08EB9
+ * @ConQAT.Rating GREEN Hash: 8A512C1E79E60FF146D0269B51227DAD
  */
 public abstract class ConnectionCompositionDragSourceAdapter extends
 		ElementCompositionDragSourceAdapter {

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionDropTargetAdapter.java

@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.service.IConnectionCompositorService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: D54893DCC7518DBBE02F92827BB2418A
+ * @ConQAT.Rating GREEN Hash: 11BB46E8DAD057A518FA32C43B985D30
  */
 public abstract class ConnectionCompositionDropTargetAdapter extends
 		DropTargetAdapter {

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ConnectionCompositionSource.java

@@ -28,7 +28,7 @@ import org.fortiss.tooling.kernel.service.IConnectionCompositorService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: F146EB39DD806F5A40DED1CA93D74F7A
+ * @ConQAT.Rating GREEN Hash: 4B7B233AD01792FF782880603219374B
  */
 public class ConnectionCompositionSource extends ElementCompositionSource {
 	/** Stores the parent element for use in connection composition. */

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDragSourceAdapter.java

@@ -34,7 +34,7 @@ import org.eclipse.swt.dnd.Transfer;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: B29FA6FC8720DBBD2AE8807F5FE9DC46
+ * @ConQAT.Rating GREEN Hash: D4F6D51798BDE2F2A8C348287E42B344
  */
 public abstract class ElementCompositionDragSourceAdapter extends
 		DragSourceAdapter {

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionDropTargetAdapter.java

@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.service.IElementCompositorService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C26BA94BBBB077835EDB9298D41E7EF5
+ * @ConQAT.Rating GREEN Hash: D5FA2315AA3F0C3CFD92E9456DE94B9A
  */
 public abstract class ElementCompositionDropTargetAdapter extends
 		DropTargetAdapter {

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/ElementCompositionSource.java

@@ -28,7 +28,7 @@ import org.fortiss.tooling.kernel.service.IElementCompositorService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C8BE422248D89555D262BED1F8815C99
+ * @ConQAT.Rating GREEN Hash: A8B1B3B73BCCAD81F00FEDD2272CD3E3
  */
 public class ElementCompositionSource {
 

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/dnd/package.html

 <!--  
   $Id: package.html 835 2011-06-28 07:31:00Z ratiu $
   @version $Rev: 835 $
-  @ConQAT.Rating YELLOW Hash: 3EA4EA7091245D0A40304F5CD8136DA9
+  @ConQAT.Rating GREEN Hash: AD7A328817E111D2DBE64C89A0405215
 -->
 <body>
 Support classes for using the SWT-based drag and drop mechanism.

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelEditor.java

@@ -26,7 +26,7 @@ import org.eclipse.ui.IEditorPart;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: CD4AF6D1FAD865473DCF9928CF7C245D
+ * @ConQAT.Rating GREEN Hash: 95A80A3A24D4CA4B5662B2416E910C8C
  */
 public interface IModelEditor<T extends EObject> extends IEditorPart {
 	/** Returns the edited object. */

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/IModelElementHandler.java

@@ -38,11 +38,14 @@ import org.fortiss.tooling.kernel.ui.service.IModelElementHandlerService;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: B70658CE4F4F97254156C590DF944C2B
+ * @ConQAT.Rating RED Hash: 4E314066E959BB2F449657AD8F254BFA
  */
 public interface IModelElementHandler<T extends EObject> extends
 		IEObjectAware<T> {
 
+	// TODO @Review CD:unsure about visibilities. possibly emphasize by using
+	// /*package*/ Object name....
+
 	/** Returns the name of the model element (if any). */
 	String getName(T element);
 
@@ -92,10 +95,4 @@ public interface IModelElementHandler<T extends EObject> extends
 	 * navigator's simplified non-expert view.
 	 */
 	boolean hiddenInNonExpertView();
-
-	/**
-	 * Handles the open model element request by returning the object that
-	 * should be passed to the model editor service.
-	 */
-	EObject handleOpenModelElementRequest(T element);
 }

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EObjectActionBase.java

@@ -27,7 +27,7 @@ import org.eclipse.jface.resource.ImageDescriptor;
  * @author hoelzlf
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 1EBE28874A90F7EC98B7FED5E6FF0214
+ * @ConQAT.Rating GREEN Hash: 9995CEA8009A5730AC380E5017A51C5F
  */
 public abstract class EObjectActionBase<T extends EObject> extends Action {
 

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/EditorBase.java

@@ -41,7 +41,7 @@ import org.fortiss.tooling.kernel.ui.internal.editor.ModelElementEditorInput;
  * @author hoelzlf
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: 8E78A5604AD81E0BA5E5124F58512E6A
+ * @ConQAT.Rating RED Hash: DF6DB4EFA6BC29413748BFF39E53C654
  */
 public abstract class EditorBase<T extends EObject> extends EditorPart
 		implements IActionContributingEditor, IModelEditor<T> {
@@ -50,9 +50,13 @@ public abstract class EditorBase<T extends EObject> extends EditorPart
 	 * The object shown in this editor. This is valid as soon as
 	 * {@link #init(IEditorSite, IEditorInput)} has been called.
 	 */
+	// TODO @Review CD:possibly final?
+	// moreover: field often called directly instead of using getter. reduce
+	// visibility?
 	protected T editedObject;
 
 	/** The model element handler to be used with the {@link #editedObject}. */
+	// TODO @Review CD: as far as I can see this can be made final
 	protected IModelElementHandler<T> handler;
 
 	/** Databinding context used for model changes. */

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/base/PropertySectionBase.java

@@ -49,7 +49,7 @@ import org.fortiss.tooling.kernel.ui.util.DataBindingUtils;
  * @author hoelzl
  * @author $Author$
  * @version $Rev$
- * @ConQAT.Rating YELLOW Hash: C933211F21A9E76CBE2281807031C684
+ * @ConQAT.Rating GREEN Hash: 532E5AECE5CF1BAB9CC2A690D10FAC34
  */
 public abstract class PropertySectionBase extends AbstractPropertySection {
 

org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/extension/data/package.html

@@ -4,6 +4,11 @@
   @ConQAT.Rating YELLOW Hash: 4937634A5C7499B64F188C4A364D8A16
 -->
 <body>
+// TODO @Review CD: I do not see obvious sufficient resemblance between this explanation and the class.
+<br>
+<br>
+
+
 Interfaces and classes for data transfer between the kernel and extensions.
 <P>
 The classes and interfaces of this package appear as parameter and result types of the