Commits · 4b9a1311f24dc149ebba9158cf2d4f97c7a0d653 · af3 / kernel

Dec 17, 2018
- GREEN · 3a32e2d3
  Hernan Ponce de Leon authored 6 years ago
  
  Issue-Ref: 3470 Signed-off-by: ponce <ponce@fortiss.org>
  3a32e2d3
Nov 29, 2018

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

b4c6e4ba

Avoid problem that property section for connectors is not shown · 12a19d99

Simon Barner authored 6 years ago

* Fixes a problem introduced in during the synchronization of the
  selection of the model editor and the model navigator (in #3084)

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

12a19d99

Update and use kernel.databinding's input validators · b785e675

Simon Barner authored 6 years ago

* No longer depend on org.conqat.ide.commons.ui.databinding.validate.*
* Improve NumberFormat validation
  * Do not accept if input contains a valid prefix
  * Provide more precise error message
  * Do not accept (1000er) grouping separator (in order to avoid
    confusion with decimal separator
* PropertySectionBase
  * Use updated validators
  * For BigDecimals, avoid introducing grouping separators during
    value -> String conversion

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

b785e675

Nov 28, 2018

Add "Text createDecoratedText()" (CAVEAT: new semantics) · a1a41e44

Simon Barner authored 6 years ago

* Creates a Text widget (with undo) and adds ControlDecoration
* "Label createDecoratedFormText()" retains the previous semantics of
  these methods, i.e. it wraps the created Text into a form entry

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

a1a41e44

createDecoratedText -> createDecoratedFormText() · e2ae649d

Simon Barner authored 6 years ago

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

e2ae649d

Integrate createFormEntryAndReturnLabel() into createFormEntry() · b4f6a2c9

Simon Barner authored 6 years ago

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

b4f6a2c9

PropertySectionBase.TextToDoubleValidator -> databinding.NumberValidator · bec9d22d

Simon Barner authored 6 years ago

* Rename singleton instance to NUMBER_VALIDATOR
* Use java.text.NumberFormat instead of the one from com.ibm.icu
* Disallow using 1000er group separator into to avoid confusions
  with decimal separator
* Accept empty input, as well as leading and trailing spaces

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582

bec9d22d

Move databinding package from base.ui to kernel.ui · 57e1002f

Simon Barner authored 6 years ago

* Retain almost all ratings ratings
* Exception: AbstractTextCellDatabindingEditingSupport, whose
  setupFieldAssist() method was removed since
   * it would have introduced a dependency to another package in
     base.ui only because is "FieldAssist" class was referenced in
     the method *comment*.
   * However, this method is only used very rarely and users of the
     class setup up their field assist in createCellEditor() instead.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

57e1002f

Disable editing of IDs using setEditable() instead setEnabled() · c9db9aeb

Simon Barner authored 6 years ago

* setEnabled(false) in createControls() has no effect, i.e. the text
  can be edited, but the change is not saved in the model. In refresh(),
  it  would have an effect, but would "gray out" the text control
* setEditable(false) prevents the user from entering text in the
  first place.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

c9db9aeb

Nov 23, 2018

Double input format validation: check if the entire string was parsed · 7c6a05a4

Simon Barner authored 6 years ago

* org.conqat.ide.commons.ui.databinding.validate.TextToDoubleValidator
  also accepted inputs where only a prefix was valid (followed by some
  garbage)
* Local version of TextToDoubleValidator checks if the entire input was
  parsed.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

7c6a05a4

Nov 21, 2018

Update tabbed property sheet title when edited input is changed · 6966477c

Simon Barner authored 6 years ago

* PropertySectionBase: Register (non-recursive) EMF notification adapter
* NamedCommentedPropertySection: special case due to input "retargeting"

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

6966477c

Add IListPropertySection::canRemoveModelListElement() · 52d56c82

Simon Barner authored 6 years ago

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

52d56c82

Nov 20, 2018

Set null value if available values do not contain the current value · b11e0874

Simon Barner authored 6 years ago

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

b11e0874

Avoid NPE when refresh()ing before the EMFDataBindingContext is set · bcc339b2

Simon Barner authored 6 years ago

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

bcc339b2

Nov 15, 2018

EReferencePropertySectionBase: bug fixes and minor improvements · 07fe54cc

Simon Barner authored 6 years ago

* Refresh entire property section when combo box is used: Need to
  complete update derived sections that add additional UI elements
* Fix management of enabled state
* Add setSelection(): safe programmatic change of combo box value

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

07fe54cc

Improve EReferenceListPropertySectionBase and make list view reusable · 755c43ce

Simon Barner authored 6 years ago

* EReferenceListPropertySectionBase
 * Introduce ElementListViewerComposite: Reusable Composite that
   provides a ListViewer & add/remove buttons
 * Usability improvements: enabled state of buttons, auto-select
   next element after "remove" operation
* Introduce IListPropertySection
  * To be implemented by classes that want to embed
    ElementListViewerComposite
  * Provides interface to data model

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

755c43ce

Nov 14, 2018
- GREEN · ea9f3061
  Hernan Ponce de Leon authored 6 years ago
  
  Issue-Ref: 3474 Signed-off-by: ponce <ponce@fortiss.org>
  ea9f3061
Nov 13, 2018

LoggingService: YELLOW · 7ef7daac

Alexander Diewald authored 6 years ago

Issue-Ref: 3574
Issue-Url: https://af3-developer.fortiss.org/issues/3574


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

7ef7daac

RED · 99e70852
Hernan Ponce de Leon authored 6 years ago and Alexander Diewald committed 6 years ago
```
Issue-Ref: 3474
Signed-off-by: ponce <ponce@fortiss.org>
```
99e70852

Implement a default dialog for the logging service. · 11d6ddd0

Alexander Diewald authored 6 years ago

* Add a default dialog and handler class.
* Move the main parts of the service from the base plugin to the kernel.
* Introduce a severity enum since using int "codes" is flawed and we do
  not use underlying eclipse methods like the logging methods in the
  LoggingUtils class.

Issue-Ref: 3574
Issue-Url: https://af3-developer.fortiss.org/issues/3574


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

11d6ddd0

GREEN · 8cb3786f
Hernan Ponce de Leon authored 6 years ago
```
Issue-Ref: 3569
Signed-off-by: ponce <ponce@fortiss.org>
```
8cb3786f

Nov 12, 2018

Add property section base class for editing EReference} lists. · 506532a0

Simon Barner authored 6 years ago

* Uses EReferencePropertySectionBase's combobox to select model element
  to be added to the list
  * See ProvideEReferencePropertySectionBase::{get,set}ModelValue().
    Declare are because of special semantics
  * Derived classes must implement getValues() (and the abstract
    methods defined in this class EReferenceListPropertySectionBase)

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

506532a0

Nov 07, 2018

Add observeVisible() · 2575a47a

Simon Barner authored 6 years ago

* As replacement for the now deprecated
  SWTObservables.observeVisible()

Issue-Ref: 3569
Issue-Url: https://af3-developer.fortiss.org/issues/3569



Signed-off-by: Simon Barner <barner@fortiss.org>

2575a47a

Add observeSelection() · 8f112fc1

Simon Barner authored 6 years ago

* As replacement for the now deprecated
  SWTObservables.observeSelection()

Issue-Ref: 3569
Issue-Url: https://af3-developer.fortiss.org/issues/3569



Signed-off-by: Simon Barner <barner@fortiss.org>

8f112fc1

Oct 22, 2018

GREEN · c01d8a60

Alexander Diewald authored 6 years ago


Issue-Ref: 3223
Signed-off-by: Alexander Diewald <diewald@fortiss.org>

c01d8a60

Oct 12, 2018

HierarchicalNameComparator: Change from EObject to Object · 4fd569a0

Simon Barner authored 6 years ago

* All clients of this class performed a type check

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

4fd569a0

Move HierarchicalNameViewerComparator to kernel.ui · 5be1d922

Simon Barner authored 6 years ago

* Generalize interface to IModelElement
* Use anonymous class in GenericAnnotationView to adapt AnnotationEntry
  elements

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

5be1d922

Oct 05, 2018

GREEN · 8f349e70

Hernan Ponce de Leon authored 6 years ago


Issue-Ref: 3545
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

8f349e70

selectAll(): make private and return empty list instead of null · f9dedd8f

Simon Barner authored 6 years ago

* Return empty list instead of null on unexpected input (null or wrong
  selection type)
* Fixes NPE in setSelection()

Issue-Ref: 3545
Issue-Url: https://af3-developer.fortiss.org/issues/3545



Signed-off-by: Simon Barner <barner@fortiss.org>

f9dedd8f

Oct 04, 2018

GREEN · 69d5cc89

Simon Barner authored 6 years ago

* Previous GREEN rating in a57ba1f9 has
  erroneously been turned to yellow when merging

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

69d5cc89

Review: mostly GREEN · ec7e102a
Hernan Ponce de Leon authored 6 years ago
```
Issue-Ref: 3539
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>
```
ec7e102a

registerConstraintUI(): Fix check for duplicate UI registrations · e5008af8

Simon Barner authored 6 years ago

* Check for duplicates was based on "cstrClass" (of type Class), whereas
  the registration is based on the class name
* Note: This change does not affect the actual registration, hence no
  change in behavior is expected.
* Revealed by warning on unlikely argument of (type Class) for
  string2cstrMap.get()

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

e5008af8

FontMetrics.getAverageCharWidth() -> getAverageCharacterWidth() · 7995b049

Simon Barner authored 6 years ago

* FontMetrics.getAverageCharWidth() has been deprecated

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

7995b049

Avoid warning about raw type · 63372ad7

Simon Barner authored 6 years ago

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

63372ad7

SWTObservables.observeText() -> DataBindingUtils.observeText() · f6aed7e5

Simon Barner authored 6 years ago

* SWTObservables is deprecated
* Add drop-in replacement of observeText() in DataBindingUtils that uses
  the new API

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

f6aed7e5

Avoid warnings about unchecked casts · 4653cf4d

Simon Barner authored 6 years ago

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

4653cf4d

Oct 02, 2018

GREEN · a57ba1f9

Hernan Ponce de Leon authored 6 years ago


Issue-Ref: 3540
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

a57ba1f9

Navigator: Show Projects after startup. · 6724c773

Alexander Diewald authored 6 years ago

* Since migrating to Photon, the listeners of the IPersistencyService
  must be seemingly installed in the init phase. By that, the
  corresponding listeners are also aware of model loading.
* Also, remove an unneeded cast to avoid a warning.

Issue-Ref: 3540
Issue-Url: https://af3-developer.fortiss.org/issues/3540


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

6724c773

Remove unnecessary casts · 5e2d9c9d

Simon Barner authored 6 years ago

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

5e2d9c9d