Issue-Ref: 3725
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

Issue-Ref: 3620
Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3620
Issue-Url: https://af3-developer.fortiss.org/issues/3620


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3620
Issue-Url: https://af3-developer.fortiss.org/issues/3620


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3618
Issue-Url: https://af3-developer.fortiss.org/issues/3618


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* Only react on EMF events when INamedElement::name is set
  (this is supposed to resolve the "SWT Widget is disposed" exception)
* Ensure that update is perform from the UI context. The underlying
  model change could be programmatic and triggered from a different
  thread (resolves "SWTException: Invalid thread access")

Issue-Ref: 3618
Issue-Url: https://af3-developer.fortiss.org/issues/3618



Signed-off-by: Simon Barner <barner@fortiss.org>

* Refer to the modular JDK-11 in the classpath.
* Depend on openjfx plugins from Tom Schindl.

Issue-Ref: 3620
Issue-Url: https://af3-developer.fortiss.org/issues/3620


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3470
Signed-off-by: ponce <ponce@fortiss.org>

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* Fixes a problem introduced in during the synchronization of the
  selection of the model editor and the model navigator (in #3084)

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

* No longer depend on org.conqat.ide.commons.ui.databinding.validate.*
* Improve NumberFormat validation
  * Do not accept if input contains a valid prefix
  * Provide more precise error message
  * Do not accept (1000er) grouping separator (in order to avoid
    confusion with decimal separator
* PropertySectionBase
  * Use updated validators
  * For BigDecimals, avoid introducing grouping separators during
    value -> String conversion

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

* Creates a Text widget (with undo) and adds ControlDecoration
* "Label createDecoratedFormText()" retains the previous semantics of
  these methods, i.e. it wraps the created Text into a form entry

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

* Rename singleton instance to NUMBER_VALIDATOR
* Use java.text.NumberFormat instead of the one from com.ibm.icu
* Disallow using 1000er group separator into to avoid confusions
  with decimal separator
* Accept empty input, as well as leading and trailing spaces

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582

* Retain almost all ratings ratings
* Exception: AbstractTextCellDatabindingEditingSupport, whose
  setupFieldAssist() method was removed since
   * it would have introduced a dependency to another package in
     base.ui only because is "FieldAssist" class was referenced in
     the method *comment*.
   * However, this method is only used very rarely and users of the
     class setup up their field assist in createCellEditor() instead.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

* setEnabled(false) in createControls() has no effect, i.e. the text
  can be edited, but the change is not saved in the model. In refresh(),
  it  would have an effect, but would "gray out" the text control
* setEditable(false) prevents the user from entering text in the
  first place.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

* org.conqat.ide.commons.ui.databinding.validate.TextToDoubleValidator
  also accepted inputs where only a prefix was valid (followed by some
  garbage)
* Local version of TextToDoubleValidator checks if the entire input was
  parsed.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

* PropertySectionBase: Register (non-recursive) EMF notification adapter
* NamedCommentedPropertySection: special case due to input "retargeting"

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

* Refresh entire property section when combo box is used: Need to
  complete update derived sections that add additional UI elements
* Fix management of enabled state
* Add setSelection(): safe programmatic change of combo box value

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

* EReferenceListPropertySectionBase
 * Introduce ElementListViewerComposite: Reusable Composite that
   provides a ListViewer & add/remove buttons
 * Usability improvements: enabled state of buttons, auto-select
   next element after "remove" operation
* Introduce IListPropertySection
  * To be implemented by classes that want to embed
    ElementListViewerComposite
  * Provides interface to data model

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3474
Signed-off-by: ponce <ponce@fortiss.org>

Issue-Ref: 3574
Issue-Url: https://af3-developer.fortiss.org/issues/3574


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Hernan Ponce de Leon authored 6 years ago and Alexander Diewald committed 6 years ago

Issue-Ref: 3474
Signed-off-by: ponce <ponce@fortiss.org>

* Add a default dialog and handler class.
* Move the main parts of the service from the base plugin to the kernel.
* Introduce a severity enum since using int "codes" is flawed and we do
  not use underlying eclipse methods like the logging methods in the
  LoggingUtils class.

Issue-Ref: 3574
Issue-Url: https://af3-developer.fortiss.org/issues/3574


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3569
Signed-off-by: ponce <ponce@fortiss.org>

* Uses EReferencePropertySectionBase's combobox to select model element
  to be added to the list
  * See ProvideEReferencePropertySectionBase::{get,set}ModelValue().
    Declare are because of special semantics
  * Derived classes must implement getValues() (and the abstract
    methods defined in this class EReferenceListPropertySectionBase)

Issue-Ref: 3470
Issue-Url: https://af3-developer.fortiss.org/issues/3470



Signed-off-by: Simon Barner <barner@fortiss.org>

* As replacement for the now deprecated
  SWTObservables.observeVisible()

Issue-Ref: 3569
Issue-Url: https://af3-developer.fortiss.org/issues/3569



Signed-off-by: Simon Barner <barner@fortiss.org>

* As replacement for the now deprecated
  SWTObservables.observeSelection()

Issue-Ref: 3569
Issue-Url: https://af3-developer.fortiss.org/issues/3569



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3223
Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* All clients of this class performed a type check

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

* Generalize interface to IModelElement
* Use anonymous class in GenericAnnotationView to adapt AnnotationEntry
  elements

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3545
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

* Return empty list instead of null on unexpected input (null or wrong
  selection type)
* Fixes NPE in setSelection()

Issue-Ref: 3545
Issue-Url: https://af3-developer.fortiss.org/issues/3545



Signed-off-by: Simon Barner <barner@fortiss.org>

* Previous GREEN rating in a57ba1f9 has
  erroneously been turned to yellow when merging

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3539
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

* Check for duplicates was based on "cstrClass" (of type Class), whereas
  the registration is based on the class name
* Note: This change does not affect the actual registration, hence no
  change in behavior is expected.
* Revealed by warning on unlikely argument of (type Class) for
  string2cstrMap.get()

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>