[3924] Fix small bugs in fx diagram editor
Fixes various minor things that came up when updating the security plugin.
Merge request reports
Activity
added 38 commits
-
9aff21b6...7de36295 - 37 commits from branch
master - 151a5eec - Merge branch 'master' into 3924
-
9aff21b6...7de36295 - 37 commits from branch
assigned to @eder
@schoepp Please check code and also merge master again. Maybe it would be good to discuss and check if the diagram changes are valid for all digrams in AF3 or just specific ones?
About the division by zero: Note that this is floating point arithmetic and there won't be an ArithmeticException :). The IEEE standard defines 1.0 / 0.0 to be "Infinity", which one can use in further calculation, and I've added a comment that in this case the result is correct. I could add a special case for 0.0, but for values very close to 0.0 one needs to check stability anyway.
About the need for the change to angle calculation: Here is a small test case AF3-Project.af3_23 to see the bug. Open the state automaton and try to move the exit port along the border of the ellipse. The port will sometimes move slower than the mouse, sometimes faster. The coordinate calculation from the angle isn't right for ellipses. The fix corrects that ant the port will be under the mouse.
added 27 commits
-
f1dfabf4...c25294b3 - 26 commits from branch
master - 6c9f870a - # WARNING: head commit changed in the meantime
-
f1dfabf4...c25294b3 - 26 commits from branch
mentioned in commit da5186d4