-
- Downloads
Improve error messages for invalid content (#377)
Previously we returned an HTTP 500 "error canonicalizing entry" error if
Rekor was unable to parse or verify the proposed content of a new log
entry. This adds a new error type ValidationError that allows
implementers of the Canonicalize method to delineate between internal,
transient errors and errors that clients can rectify.
With this patch, errors parsing or validating (provided or referenced)
artifacts will return an HTTP 400 message to the client with a message
about the issue.
Fixes: #362
Signed-off-by:
Bob Callaway <bob.callaway@gmail.com>
Showing
- pkg/api/entries.go 4 additions, 1 deletionpkg/api/entries.go
- pkg/api/error.go 1 addition, 0 deletionspkg/api/error.go
- pkg/pki/x509/x509.go 2 additions, 2 deletionspkg/pki/x509/x509.go
- pkg/types/README.md 4 additions, 0 deletionspkg/types/README.md
- pkg/types/alpine/v0.0.1/entry.go 9 additions, 5 deletionspkg/types/alpine/v0.0.1/entry.go
- pkg/types/alpine/v0.0.1/entry_test.go 4 additions, 0 deletionspkg/types/alpine/v0.0.1/entry_test.go
- pkg/types/error.go 20 additions, 0 deletionspkg/types/error.go
- pkg/types/helm/v0.0.1/entry.go 6 additions, 15 deletionspkg/types/helm/v0.0.1/entry.go
- pkg/types/helm/v0.0.1/entry_test.go 4 additions, 0 deletionspkg/types/helm/v0.0.1/entry_test.go
- pkg/types/intoto/v0.0.1/entry.go 1 addition, 6 deletionspkg/types/intoto/v0.0.1/entry.go
- pkg/types/jar/v0.0.1/entry.go 10 additions, 15 deletionspkg/types/jar/v0.0.1/entry.go
- pkg/types/jar/v0.0.1/entry_test.go 4 additions, 0 deletionspkg/types/jar/v0.0.1/entry_test.go
- pkg/types/rekord/v0.0.1/entry.go 6 additions, 6 deletionspkg/types/rekord/v0.0.1/entry.go
- pkg/types/rekord/v0.0.1/entry_test.go 4 additions, 0 deletionspkg/types/rekord/v0.0.1/entry_test.go
- pkg/types/rfc3161/v0.0.1/entry_test.go 4 additions, 0 deletionspkg/types/rfc3161/v0.0.1/entry_test.go
- pkg/types/rpm/v0.0.1/entry.go 6 additions, 6 deletionspkg/types/rpm/v0.0.1/entry.go
- pkg/types/rpm/v0.0.1/entry_test.go 5 additions, 0 deletionspkg/types/rpm/v0.0.1/entry_test.go
- tests/e2e_test.go 4 additions, 0 deletionstests/e2e_test.go
Loading
Please register or sign in to comment