Skip to content
Snippets Groups Projects
Commit 2cc9b701 authored by Daniel Ratiu's avatar Daniel Ratiu
Browse files

another code review iteration is performed

parent 396367d8
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
Showing
with 28 additions and 19 deletions
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/EObjectDragSourceListener.java
+ 1
− 1
View file @ 2cc9b701
......@@ -29,7 +29,7 @@ import org.eclipse.swt.dnd.DragSourceEvent;
* @author eder
* @author $Author: hoelzl $
* @version $Rev: 18709 $
* @ConQAT.Rating YELLOW Hash: 7274445CF4D8976F98D2261373206375
* @ConQAT.Rating GREEN Hash: E21E2799DA5A521B7B102FCF933556F5
*/
public class EObjectDragSourceListener extends DragSourceAdapter {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/LibraryView.java
+ 1
− 1
View file @ 2cc9b701
......@@ -53,7 +53,7 @@ import org.fortiss.tooling.kernel.ui.services.IModelElementService;
* @author eder
* @author $Author: hoelzl $
* @version $Rev: 18709 $
* @ConQAT.Rating YELLOW Hash: D385105D51E1CFDED0B8FF4E855A2B94
* @ConQAT.Rating GREEN Hash: BE7BE3DF4D235818552B6BAD3CED5CB0
*/
public class LibraryView extends ViewPart {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeContentProvider.java
+ 1
− 1
View file @ 2cc9b701
......@@ -34,7 +34,7 @@ import org.fortiss.tooling.kernel.ui.services.IModelElementService;
* @author hoelzlf
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: B99F9C3252CFF2333B31E7075D035057
* @ConQAT.Rating GREEN Hash: 153C112080D4CC28DFB6D64190846CEA
*/
public class NavigatorTreeContentProvider implements ITreeContentProvider {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorTreeLabelProvider.java
+ 1
− 1
View file @ 2cc9b701
......@@ -30,7 +30,7 @@ import org.fortiss.tooling.kernel.ui.services.IModelElementService;
* @author hoelzlf
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 576FB18EB32B79705C9E03CB910F68CB
* @ConQAT.Rating GREEN Hash: ADCF367C35F16C4D1ECB25BC16DE088E
*/
public final class NavigatorTreeLabelProvider extends BaseLabelProvider
implements ILabelProvider {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NavigatorViewPart.java
+ 3
− 0
View file @ 2cc9b701
......@@ -147,6 +147,9 @@ public final class NavigatorViewPart extends ViewPart implements
.getActionBars());
createLinkWithEditorAction();
// TODO: the "magic chains" like
// "PlatformUI.getWorkbench().getActiveWorkbenchWindow()"
// are good candidates to be part of utility classes
PlatformUI.getWorkbench().getActiveWorkbenchWindow()
.getSelectionService().addSelectionListener(this);
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/NewMenu.java
+ 5
− 2
View file @ 2cc9b701
......@@ -35,6 +35,9 @@ import org.fortiss.tooling.kernel.ui.util.EObjectSelectionUtils;
/**
* The contributor for the dynamic new menu based on composition.
*
* TODO: package name from the copyright comment "edu.tum.cs.ccts.model.base" is
* outdated.
*
* @author hoelzlf
* @author $Author$
* @version $Rev$
......@@ -105,8 +108,8 @@ public class NewMenu extends CompoundContributionItem {
@Override
public void run() {
EObject newObject = prototype.getPrototypeCopy();
if (IElementCompositorService.INSTANCE.compose(container,
newObject, null)) {
if (IElementCompositorService.INSTANCE.compose(
container, newObject, null)) {
IEditorService.INSTANCE.openInEditor(newObject);
}
}
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/internal/views/package.html
+ 1
− 1
View file @ 2cc9b701
<!--
$Id$
@version $Rev$
@ConQAT.Rating YELLOW Hash: 527D9BF51495443E95F62CF8C27B4AA8
@ConQAT.Rating GREEN Hash: 198A5F9B0AFF625D7F74C572F760E0B0
-->
<body>
Implementations of the navigator and model element library view.
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/package.html
+ 1
− 1
View file @ 2cc9b701
<!--
$Id$
@version $Rev$
@ConQAT.Rating YELLOW Hash: 0105A489AFAD9D13B3E1D45D150E7818
@ConQAT.Rating GREEN Hash: 0DE01A78A3A55B1500DEA7D846AED2BB
-->
<body>
Main plugin package for fortiss tooling kernel user-interface.
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IActionService.java
+ 1
− 1
View file @ 2cc9b701
......@@ -28,7 +28,7 @@ import org.fortiss.tooling.kernel.ui.internal.ActionService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 2B3895F36532E6A497B12746C07D91D8
* @ConQAT.Rating GREEN Hash: D76C66B8F522789D7C16221291D8D389
*/
public interface IActionService {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IEditPartFactoryService.java
+ 1
− 1
View file @ 2cc9b701
......@@ -29,7 +29,7 @@ import org.fortiss.tooling.kernel.ui.internal.EditPartFactoryService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 465A71657359ABBCD0BE5F70815436B1
* @ConQAT.Rating GREEN Hash: 2E7D6A7BEE050894ABDAE02CD4BC95FD
*/
public interface IEditPartFactoryService extends EditPartFactory {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IEditorService.java
+ 1
− 1
View file @ 2cc9b701
......@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.ui.internal.EditorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: ECCFA2C956D54381EC206F79876D8BC1
* @ConQAT.Rating GREEN Hash: 9A727CA1B177F99AD5448AF5223713CE
*/
public interface IEditorService {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IModelElementService.java
+ 3
− 0
View file @ 2cc9b701
......@@ -25,6 +25,9 @@ import org.fortiss.tooling.kernel.ui.internal.ModelElementService;
* The model context service provides information about registered model
* elements.
*
* TODO is the above line ok? "The model context service" ->
* "The model element service"? TODO where are the elements registered?
*
* @see IModelElementHandler
*
* @author hoelzl
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/INavigatorService.java
+ 1
− 1
View file @ 2cc9b701
......@@ -35,7 +35,7 @@ import org.fortiss.tooling.kernel.ui.internal.NavigatorService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 66B5DD3650C883C2E70023247D11A811
* @ConQAT.Rating GREEN Hash: 42753D9AF5F66074E37F6F1C9A5587F6
*/
public interface INavigatorService {
/** Returns the singleton instance of the service. */
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/IPropertiesService.java
+ 1
− 1
View file @ 2cc9b701
......@@ -41,7 +41,7 @@ import org.fortiss.tooling.kernel.ui.internal.PropertiesService;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 2A09E8B8BA89FFD035F4D9AE28DCE6AA
* @ConQAT.Rating GREEN Hash: 8844965F80E0B2B5EC5E652DCA614246
*/
public interface IPropertiesService {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/services/package.html
+ 2
− 2
View file @ 2cc9b701
<!--
$Id$
@version $Rev$
@ConQAT.Rating YELLOW Hash: 3B94D166F87E14036D796F029CBD8668
@ConQAT.Rating GREEN Hash: D0AEC7D22C9850BA730348BFF845F594
-->
<body>
Interface definitions of the kernel UI services. Each interface corresponds to a certain functionality of the user-interface part of the kernel.
Some of the services provide extension points. Extension implementors should refer to the <code>kernel.ui.interfaces</code>
and <code>kernel.ui.base</code>m packages. Kernel services are implemented by classes from the <code>kernel.ui.internal.services</code> package.
and <code>kernel.ui.base</code> packages. Kernel services are implemented by classes from the <code>kernel.ui.internal.services</code> package.
</body>
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/DataBindingUtils.java
+ 1
− 1
View file @ 2cc9b701
......@@ -35,7 +35,7 @@ import org.eclipse.swt.widgets.Control;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 646DA3B438CB4A6FCF6D7740388C0373
* @ConQAT.Rating GREEN Hash: 1AA4C5FB4C31B3AEDFC4627BFCA48F02
*/
public final class DataBindingUtils {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/DragAndDropUtils.java
+ 1
− 1
View file @ 2cc9b701
......@@ -27,7 +27,7 @@ import org.fortiss.tooling.kernel.services.IPrototypeService.Prototype;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 338194B154464E27FA65CDCD72CE7439
* @ConQAT.Rating GREEN Hash: DC84E260F9545A3D493A8A732C131495
*/
public final class DragAndDropUtils {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/EObjectSelectionUtils.java
+ 1
− 1
View file @ 2cc9b701
......@@ -33,7 +33,7 @@ import org.eclipse.ui.PlatformUI;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: C89BCA60DC06B35E1946C57DD21D8769
* @ConQAT.Rating GREEN Hash: A8D571A5DA7E4057916EA1DD96006069
*/
public final class EObjectSelectionUtils {
......
org.fortiss.tooling.kernel.ui/trunk/src/org/fortiss/tooling/kernel/ui/util/package.html
+ 1
− 1
View file @ 2cc9b701
<!--
$Id$
@version $Rev$
@ConQAT.Rating YELLOW Hash: E4E985E2A87DF1B3EEA0438D26921D62
@ConQAT.Rating GREEN Hash: DEFFB68B2947CAE93354983FBBF37AD5
-->
<body>
Utility methods provided by the user-interface part of the kernel.
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment