Skip to content
Snippets Groups Projects
Commit 48b180be authored by Daniel Ratiu's avatar Daniel Ratiu
Browse files

Yet another review of the code.

parent 79980e69
No related branches found
No related tags found
No related merge requests found
Showing
with 34 additions and 28 deletions
......@@ -27,7 +27,7 @@ import org.fortiss.tooling.base.model.layout.ILayoutedModelElement;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 6CDD3F1694F0E50432432EBBF3DA82A4
* @ConQAT.Rating GREEN Hash: 8FB6A5E20076ECFAB90EB559B84E4C2A
*/
public abstract class BendpointCommandBase extends Command {
......
......@@ -34,7 +34,7 @@ import org.fortiss.tooling.base.ui.layout.util.LayoutDataUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 97E72763FD3655AAF658FF43EAA8C3CF
* @ConQAT.Rating GREEN Hash: F47DE8BFDA3950070E5EFC6DAEB4D8C4
*/
public abstract class ChangeBoundsRequestCommandBase extends Command {
......
......@@ -27,12 +27,12 @@ import org.fortiss.tooling.kernel.service.IConnectionCompositorService;
/**
* This command is used by {@link ConnectionGraphicalNodeEditPolicy} to
* communicate with the connector service.
* communicate with {@link IConnectionCompositorService}.
*
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: B0F33CCD646C725CE690BDB141193612
* @ConQAT.Rating GREEN Hash: 00634D0BD9758BDAF4449AFE77C1087D
*/
public class ConnectionCommand extends Command {
......@@ -62,9 +62,9 @@ public class ConnectionCommand extends Command {
}
if (context.getSource().getModel() instanceof EObject
&& context.getTarget().getModel() instanceof EObject) {
return IConnectionCompositorService.INSTANCE.canConnect((EObject) context
.getSource().getModel(), (EObject) context.getTarget()
.getModel(), connection, context);
return IConnectionCompositorService.INSTANCE.canConnect(
(EObject) context.getSource().getModel(), (EObject) context
.getTarget().getModel(), connection, context);
}
return false;
}
......@@ -72,8 +72,8 @@ public class ConnectionCommand extends Command {
/** {@inheritDoc} */
@Override
public void execute() {
IConnectionCompositorService.INSTANCE.connect((EObject) context.getSource()
.getModel(), (EObject) context.getTarget().getModel(),
connection, context);
IConnectionCompositorService.INSTANCE.connect((EObject) context
.getSource().getModel(), (EObject) context.getTarget()
.getModel(), connection, context);
}
}
......@@ -28,7 +28,7 @@ import org.fortiss.tooling.base.ui.layout.util.LayoutDataUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: F116BF8DD007FAB3A0EA25C09A7B48BB
* @ConQAT.Rating GREEN Hash: F2CCAB8DDBF1645FD902C45F5A115988
*/
public class CreateBendpointCommand extends BendpointCommandBase {
......
......@@ -26,7 +26,7 @@ import org.fortiss.tooling.base.ui.layout.util.LayoutDataUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 1199086FE886DBF2B151CC79C21F48C9
* @ConQAT.Rating GREEN Hash: 8065D7B4FC73CC70C9CB1FE3290018D9
*/
public class DeleteBendpointCommand extends BendpointCommandBase {
/** Creates a command to delete a bend point. */
......
......@@ -28,7 +28,7 @@ import org.fortiss.tooling.base.ui.layout.util.LayoutDataUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 83BD91B4E187EEE6AAE9948532F3227F
* @ConQAT.Rating GREEN Hash: E24E7BBFF3601BFCFDF0F03ED5BCC2D2
*/
public class MoveBendpointCommand extends BendpointCommandBase {
......
......@@ -36,7 +36,7 @@ import org.fortiss.tooling.base.ui.layout.util.LayoutDataUtils;
* @author hoelzlf
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 44F8907016E9D390775ACCF4FC5FA5E8
* @ConQAT.Rating GREEN Hash: E806F6189F17B9B9E2A126FB5432A81A
*/
public class MoveConnectorCommand extends ChangeBoundsRequestCommandBase {
......
......@@ -32,7 +32,7 @@ import org.fortiss.tooling.base.ui.layout.constants.DefaultLayoutConstants;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 4ECC57F8884FDDF3C622F30A50353585
* @ConQAT.Rating GREEN Hash: D3A1601F1C27EAEC5CDDB52971822FF8
*/
public class MoveWithinDiagramCommand extends ChangeBoundsRequestCommandBase {
......
......@@ -26,10 +26,13 @@ import org.fortiss.tooling.kernel.extension.data.IConnectionCompositionContext;
* i.e. the source edit part and the location w.r.t. this edit part and the
* target edit part and the location w.r.t. this edit part.
*
* TODO: the class comments of {@link DragContext} and {@link DropContext} are
* highly different. Can we make them more homogeneous?
*
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: A575B082D1C9D00D4F3DA25290D04715
* @ConQAT.Rating RED Hash: 3C9A44958574E4B1F774160841886315
*/
public class DragContext implements IConnectionCompositionContext {
......
......@@ -30,10 +30,13 @@ import org.fortiss.tooling.kernel.extension.data.IElementCompositionContext;
* The editpart can also be a diagram edit part, e.g. the background of some
* diagram editor.
*
* TODO: the class comments of {@link DragContext} and {@link DropContext} are
* highly different. Can we make them more homogeneous?
*
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 9BC9334824938F81319860D8E7CAFB27
* @ConQAT.Rating RED Hash: 70B8E48635907E7922445C6DBE918F76
*/
public class DropContext implements IElementCompositionContext {
......
/*--------------------------------------------------------------------------+
$Id$
$Id$
| |
| Copyright 2011 ForTISS GmbH |
| |
......@@ -35,7 +35,7 @@ import org.fortiss.tooling.base.ui.editor.gef.GraphicalViewerEditorBase;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 45BCB098D77D69D38DD9D04140703745
* @ConQAT.Rating GREEN Hash: 8254A8D604E8FA36921DB38A8F8C717B
*/
public class DropTargetListener extends AbstractTransferDropTargetListener {
......
......@@ -51,7 +51,7 @@ import org.eclipse.gef.editparts.ScalableRootEditPart;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: F8855E6AA03A3F8215C9BA073623B464
* @ConQAT.Rating GREEN Hash: 6AE34957657F23D48142F8C130CCC547
*/
public class ExtendedLayerRootEditPart extends ScalableRootEditPart {
/** The node layer ID. */
......
......@@ -28,7 +28,7 @@ import org.eclipse.draw2d.geometry.Point;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: E1FF5315EEFE58AA002CC01E97F619C6
* @ConQAT.Rating GREEN Hash: B537BA7FE701844831A67814A81C95C1
*/
public class InsetChopBoxConnectionAnchor extends ChopboxAnchor {
......
......@@ -27,7 +27,7 @@ import org.eclipse.swt.SWT;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 07C86FB2361E45881CEB859B453E3F4F
* @ConQAT.Rating GREEN Hash: 04CA591F54FA5127E1F4933E9FB55449
*/
public class AntiAliasedEllipse extends Ellipse {
......
......@@ -32,7 +32,7 @@ import org.fortiss.tooling.kernel.extension.data.IConstraintViolation;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 4E2A474E77547ACB0DF8C8D25A21C743
* @ConQAT.Rating GREEN Hash: 941368BC6513E660CDC25E44EB53F349
*/
public class DecoratorFigure extends Label {
......
......@@ -28,7 +28,7 @@ import org.fortiss.tooling.base.ui.ToolingBaseUIActivator;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: B5D40E290043ECEE13218F5DA589AFB5
* @ConQAT.Rating GREEN Hash: A56EAF879DF84E2265CA1617D0E8C55F
*/
public enum EVisualStyle {
/** Traditional (since 2007) CCTS style with soft gradients. */
......
......@@ -40,7 +40,7 @@ import org.eclipse.ui.plugin.AbstractUIPlugin;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 6532DB99FCD990C052DA0B8D0957D3E2
* @ConQAT.Rating GREEN Hash: CF233E62948846C66408FEE3848CFBDE
*/
public class PrettyInsetEllipse extends Shape {
......
......@@ -38,7 +38,7 @@ import org.fortiss.tooling.base.ui.ToolingBaseUIActivator;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: BF9CBEC805A24099FC3782B3DAFD11CE
* @ConQAT.Rating GREEN Hash: 3FE067E8F618DE4394D10876405951A7
*/
public class PrettyRoundedRectangle extends Shape {
......
......@@ -36,7 +36,7 @@ import org.fortiss.tooling.base.ui.layout.util.SnapToGridUtils;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 798A66B49EB8A53551DAFDE6BB690C3E
* @ConQAT.Rating GREEN Hash: E77983D22C4E49D977F8A4BC13E34D85
*/
public class ConnectionBendpointEditPolicy<T extends ILayoutedModelElement & IConnection>
extends BendpointEditPolicy implements IPointLayouter {
......
......@@ -78,7 +78,7 @@ import org.fortiss.tooling.base.ui.dnd.DragContext;
* @author hoelzl
* @author $Author$
* @version $Rev$
* @ConQAT.Rating YELLOW Hash: 8FF043FB7B5273EEE1829448DB3F2EA8
* @ConQAT.Rating GREEN Hash: 0CE8E3EEB63110DB784B1877B7405C01
*/
public class ConnectionGraphicalNodeEditPolicy extends GraphicalNodeEditPolicy {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment