* Red: Namings in CustomUndoRedoForSourceEditor, SourceEditorBase.
* GREEN: annotations.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3536
Signed-off-by: Sudeep Kanav <kanav@fortiss.org>

Double input format validation: check if the entire string was parsed

See merge request !38

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* No longer depend on org.conqat.ide.commons.ui.databinding.validate.*
* Improve NumberFormat validation
  * Do not accept if input contains a valid prefix
  * Provide more precise error message
  * Do not accept (1000er) grouping separator (in order to avoid
    confusion with decimal separator
* PropertySectionBase
  * Use updated validators
  * For BigDecimals, avoid introducing grouping separators during
    value -> String conversion

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

* Creates a Text widget (with undo) and adds ControlDecoration
* "Label createDecoratedFormText()" retains the previous semantics of
  these methods, i.e. it wraps the created Text into a form entry

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

* Rename singleton instance to NUMBER_VALIDATOR
* Use java.text.NumberFormat instead of the one from com.ibm.icu
* Disallow using 1000er group separator into to avoid confusions
  with decimal separator
* Accept empty input, as well as leading and trailing spaces

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582

* Retain almost all ratings ratings
* Exception: AbstractTextCellDatabindingEditingSupport, whose
  setupFieldAssist() method was removed since
   * it would have introduced a dependency to another package in
     base.ui only because is "FieldAssist" class was referenced in
     the method *comment*.
   * However, this method is only used very rarely and users of the
     class setup up their field assist in createCellEditor() instead.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

* setEnabled(false) in createControls() has no effect, i.e. the text
  can be edited, but the change is not saved in the model. In refresh(),
  it  would have an effect, but would "gray out" the text control
* setEditable(false) prevents the user from entering text in the
  first place.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

* org.conqat.ide.commons.ui.databinding.validate.TextToDoubleValidator
  also accepted inputs where only a prefix was valid (followed by some
  garbage)
* Local version of TextToDoubleValidator checks if the entire input was
  parsed.

Issue-Ref: 3582
Issue-Url: https://af3-developer.fortiss.org/issues/3582



Signed-off-by: Simon Barner <barner@fortiss.org>

3474

See merge request !34

Issue-Ref: 3474
Signed-off-by: ponce <ponce@fortiss.org>

Issue-Ref: 3574
Issue-Url: https://af3-developer.fortiss.org/issues/3574


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Hernan Ponce de Leon authored 6 years ago and Alexander Diewald committed 6 years ago

Issue-Ref: 3474
Signed-off-by: ponce <ponce@fortiss.org>

Issue-Ref: 3574
Issue-Url: https://af3-developer.fortiss.org/issues/3574


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* Add a default dialog and handler class.
* Move the main parts of the service from the base plugin to the kernel.
* Introduce a severity enum since using int "codes" is flawed and we do
  not use underlying eclipse methods like the logging methods in the
  LoggingUtils class.

Issue-Ref: 3574
Issue-Url: https://af3-developer.fortiss.org/issues/3574


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

3569: Avoid warnings

See merge request !32

Issue-Ref: 3569
Signed-off-by: ponce <ponce@fortiss.org>

* As replacement for the now deprecated
  SWTObservables.observeVisible()

Issue-Ref: 3569
Issue-Url: https://af3-developer.fortiss.org/issues/3569



Signed-off-by: Simon Barner <barner@fortiss.org>

* As replacement for the now deprecated
  SWTObservables.observeSelection()

Issue-Ref: 3569
Issue-Url: https://af3-developer.fortiss.org/issues/3569



Signed-off-by: Simon Barner <barner@fortiss.org>

3517 Graphical glitch with states

See merge request !31

* Intermediate review: Issue is open for the correct solution.
* Improved documentation such that developers unfamiliar with the bug
  can understand the problem more easily.

Issue-Ref: 3517
Issue-Url: https://af3-developer.fortiss.org/issues/3517


Signed-off-by: Alexander Diewald <diewald@fortiss.org>

Issue-Ref: 3564
URL: https://af3-developer.fortiss.org/issues/3564

Issue-Ref: 3517
Signed-off-by: Filip Reaboi <reaboi@fortiss.org>

3223: Refactorying of hierarchical name (viewer) comparator

See merge request !29

Issue-Ref: 3223
Signed-off-by: Alexander Diewald <diewald@fortiss.org>

* Walk up the model hierarchy regardless if the current element
  matches the given targetClass

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

* All clients of this class performed a type check

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

* Generalize interface to IModelElement
* Use anonymous class in GenericAnnotationView to adapt AnnotationEntry
  elements

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

* This is neither tooling.base nor UI specific
* Retain GREEN ratings since there is no change in the code (only the
  class comment has slightly been updated)

Issue-Ref: 3223
Issue-Url: https://af3-developer.fortiss.org/issues/3223



Signed-off-by: Simon Barner <barner@fortiss.org>

selectAll(): make private and return empty list instead of null

See merge request !28

Issue-Ref: 3545
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>

* Return empty list instead of null on unexpected input (null or wrong
  selection type)
* Fixes NPE in setSelection()

Issue-Ref: 3545
Issue-Url: https://af3-developer.fortiss.org/issues/3545



Signed-off-by: Simon Barner <barner@fortiss.org>

3539

See merge request !27

* Previous GREEN rating in a57ba1f9 has
  erroneously been turned to yellow when merging

Issue-Ref: 3539
Issue-Url: https://af3-developer.fortiss.org/issues/3539



Signed-off-by: Simon Barner <barner@fortiss.org>

Issue-Ref: 3539
Signed-off-by: Hernan Ponce de Leon <ponce@fortiss.org>